1504034 - reduce string allocations/copying for the quotes property

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Cameron McCormack (:heycam)]

Currently the Rust-side computed value for the quotes property is produced by cloning the strings, which are then copied again into the nsStyleQuoteValues.  We can do better by sharing a single allocation of the list of quote strings in both the Rust and C++ computed value representations.

Comment 1

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a165bbb2116aaab3689380d9b088b8e014bb131

Comment 2

[Cameron McCormack (:heycam)]

Attachment: Bug 1504034 - Part 1: Make quotes property representation allocate less

Comment 3

[Cameron McCormack (:heycam)]

Attachment: Bug 1504034 - Part 2: Use Servo to serialize computed quotes values

Depends on D10650

Comment 4

[Cameron McCormack (:heycam)]

Attachment: Bug 1504034 - Part 3: Store the Rust QuotePair slice as the computed quotes value in Gecko style structs

Depends on D10651

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84a728ecbaa4
Part 1: Make quotes property representation allocate less r=emilio
https://hg.mozilla.org/integration/autoland/rev/2972602ab11d
Part 2: Use Servo to serialize computed quotes values r=emilio
https://hg.mozilla.org/integration/autoland/rev/2e5a8258ba69
Part 3: Store the Rust QuotePair slice as the computed quotes value in Gecko style structs r=emilio

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07ceb63dcfc8
Followup to address review comments. r=emilio

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c4703b12156
followup post-review nit. r=heycam

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/84a728ecbaa4
https://hg.mozilla.org/mozilla-central/rev/2972602ab11d
https://hg.mozilla.org/mozilla-central/rev/2e5a8258ba69
https://hg.mozilla.org/mozilla-central/rev/07ceb63dcfc8
https://hg.mozilla.org/mozilla-central/rev/6c4703b12156