1504038 - about:studies shows preference names and values in monospace on Linux and italics on OSX

Status: RESOLVED FIXED

(Firefox :: Normandy Client, defect)

Description

[Michael Cooper [:mythmon]]

In about:studies, the list items for Preference Experiments show the preference being changed and the new value of the preference. On Linux this shows up as italic fixed width text. On OSX it shows up as italic variable with text. It looks worse in OSX, and I think fixed width is the correct choice.

Comment 1

[Sam]

I would like to work on this, can it be assigned to me?

Thanks :)

Comment 2

[Michael Cooper [:mythmon]]

I've assigned the bug to you, thanks for the help! If you need further support, #normandy on irc.mozilla.org is a good place to find the team.

Comment 3

[Osmose [:osmose, :mkelly]]

(In reply to Michael Cooper [:mythmon] from comment #0)
> On OSX it shows up as italic variable with text. 

This doesn't appear to be true; on MacOS, I see fixed width text, and the CSS font declaration is `italic 1.0rem 'Fira Mono', 'mono', 'monospace'`.

Comment 4

[Rehan Dalal (Inactive)]

Attachment: Screen Shot 2018-11-07 at 2.25.15 PM.png

I am still seeing this issue

Comment 5

[Sam]

Any chance you could post what the computed CSS font value is? I am also seeing `italic 1.0rem 'Fira Mono', 'mono', 'monospace'`. Also what version of OSX are you on?

Comment 6

[Rehan Dalal (Inactive)]

Attachment: Screen Shot 2018-11-09 at 4.28.18 PM.png

Comment 7

[Rehan Dalal (Inactive)]

FWIW changing from 'Fira Mono', 'mono', 'monospace' to just 'monospace' fixes the issue.

Comment 8

[Rehan Dalal (Inactive)]

Actually after poking around I realized this should be changed from:

font: italic 1.0rem 'Fira Mono', 'mono', 'monospace';

To:

font: italic 1.0rem 'Fira Mono', 'mono', monospace;

That fixes the issue for me.

Comment 9

[Rehan Dalal (Inactive)]

From https://developer.mozilla.org/en-US/docs/Web/CSS/font-family#Values:

> Generic font families are a fallback mechanism, a means of preserving some of the style sheet author's intent when none of the specified fonts are available. Generic family names are keywords and must not be quoted.

Comment 10

[Peter Bengtsson [:peterbe]]

For what it's worth, both Firefox and Google Chrome deals with it the same way. https://codepen.io/peterbe/pen/NErMdQ looks identical in Nightly and Google Chrome to me on OSX.

Comment 11

[Rehan Dalal (Inactive)]

Attachment: Bug 1504038 - Fix preference name styling on OS X on about:studies

Comment 12

[Rehan Dalal (Inactive)]

Taking this bug since I've already submitted a patch.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68faf9528d57
Fix preference name styling on OS X on about:studies r=mythmon,Gijs

Comment 14

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/68faf9528d57