Closed Bug 1504131 Opened Last year Closed 11 months ago

Remove DocumentResizeEventListener and ResizerMouseMotionListener

Categories

(Core :: Editor, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

Details

Attachments

(3 files)

DocumentResizeEventListener listens to resize events of window and ResizerMouseMotionListener listens to mousemove events for handling resizers.

Fortunately, they are enough simple and neither HTMLEditorEventListener nor EditorEventListener does not listen to the events.  Therefore, we can move them into HTMLEditorEventListener.
DocumentResizeEventListener listens to only "resize" events of the window
and when it fired, it just calls HTMLEditor::RefreshResizers().  Fortunately,
neither EditorEventListener nor HTMLEditorEventListener listens to "resize"
events.  Therefore, we can move this implementation into
HTMLEditorEventListener.
ResizerMouseMotionListener listens to "mousemove" events for resizers
or grabber to move absolutely position element and it calls only
HTMLEditor::MouseMove().  Fortunately, neither EditorEventListener not
HTMLEditorEventListener listens to "mousemove" events.  Therefore, we
can use HTMLEditorEventListener instead.
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/7160ca524bf0
part 1: Remove DocumentResizeEventListener r=m_kato
https://hg.mozilla.org/integration/autoland/rev/d0a8f3df072a
part 2: Remove ResizerMouseMotionListener r=m_kato
https://hg.mozilla.org/integration/autoland/rev/7be8263d44fd
part 3: Remove editor/libeditor/HTMLEditorObjectResizerUtils.h r=m_kato
You need to log in before you can comment on or make changes to this bug.