1504131 - Remove DocumentResizeEventListener and ResizerMouseMotionListener

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

DocumentResizeEventListener listens to resize events of window and ResizerMouseMotionListener listens to mousemove events for handling resizers.

Fortunately, they are enough simple and neither HTMLEditorEventListener nor EditorEventListener does not listen to the events.  Therefore, we can move them into HTMLEditorEventListener.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4da92ca515265d96d091526d6337f214c47eac66

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4b6a15590cb8a21f28fc2bf4c3311e6aa2c9d853

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1504131 - part 1: Remove DocumentResizeEventListener

DocumentResizeEventListener listens to only "resize" events of the window
and when it fired, it just calls HTMLEditor::RefreshResizers().  Fortunately,
neither EditorEventListener nor HTMLEditorEventListener listens to "resize"
events.  Therefore, we can move this implementation into
HTMLEditorEventListener.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1504131 - part 2: Remove ResizerMouseMotionListener

ResizerMouseMotionListener listens to "mousemove" events for resizers
or grabber to move absolutely position element and it calls only
HTMLEditor::MouseMove().  Fortunately, neither EditorEventListener not
HTMLEditorEventListener listens to "mousemove" events.  Therefore, we
can use HTMLEditorEventListener instead.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1504131 - part 3: Remove editor/libeditor/HTMLEditorObjectResizerUtils.h

Now, the header file is not necessary.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7160ca524bf0
part 1: Remove DocumentResizeEventListener r=m_kato
https://hg.mozilla.org/integration/autoland/rev/d0a8f3df072a
part 2: Remove ResizerMouseMotionListener r=m_kato
https://hg.mozilla.org/integration/autoland/rev/7be8263d44fd
part 3: Remove editor/libeditor/HTMLEditorObjectResizerUtils.h r=m_kato

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/7160ca524bf0
https://hg.mozilla.org/mozilla-central/rev/d0a8f3df072a
https://hg.mozilla.org/mozilla-central/rev/7be8263d44fd