1504164 - Enable new certificate error pages on Beta by default

Status: RESOLVED FIXED

(Firefox :: Security, enhancement, P1)

Description

[Johann Hofmann [:johannh]]

According to https://bugzilla.mozilla.org/show_bug.cgi?id=1501004#c6 we will test the new certificate error pages in release.

We should enable them for the Beta population to have a larger test audience.

Comment 1

[Johann Hofmann [:johannh]]

Attachment: Bug 1504164 - Enable new certificate error pages on Beta by default. r=nhnt11

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b55684fba8a2
Enable new certificate error pages on Beta by default. r=nhnt11

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b55684fba8a2

Comment 4

[Johann Hofmann [:johannh]]

Comment on attachment 9022544 [details]
Bug 1504164 - Enable new certificate error pages on Beta by default. r=nhnt11

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: None

User impact if declined: N/A, this is enabling a new feature (new certificate error pages) we'd like to test in Beta

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce: This feature already has its own QA assigned.

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Just a pref flip, limited to beta for now, will be QAed on Beta.

String changes made/needed: None

Comment 5

[Julien Cristau [:jcristau]]

We're about to turn off "early beta" this week.  Is this still worth it?

Comment 6

[Julien Cristau [:jcristau]]

If we want to give this some exposure on the beta population in 64, an alternative to this patch that doesn't depend on EARLY_BETA is to run a shield pref experiment on beta, that would let us roll this out to a subset of users?

Comment 7

[Julien Cristau [:jcristau]]

Another possibility would be to enable if MOZ_DEV_EDITION.

Comment 8

[Johann Hofmann [:johannh]]

Actually, that's okay, since we're doing the shield study on 64 we'll bound to get beta exposure on 65 as well, that should be enough. Feel free to deny the approval. Thanks!

Comment 9

[Alexandru Simonca [:asimonca], Release Desktop QA]

So, is the uplift still scheduled for next week? Should we still keep this feature on our radar for this cycle? We are currently testing features for pre-Release sign-offs and I would need the updated feature in Beta next week so that I can test it in time.

Comment 10

[Julien Cristau [:jcristau]]

Comment on attachment 9022544 [details]
Bug 1504164 - Enable new certificate error pages on Beta by default. r=nhnt11

This will not be turned on by default in 64.  It'll be enabled as part of a shield study for a subset of users.

Comment 11

[Johann Hofmann [:johannh]]

(In reply to Alexandru Simonca [:asimonca], Release Desktop QA from comment #9)
> So, is the uplift still scheduled for next week? Should we still keep this
> feature on our radar for this cycle? We are currently testing features for
> pre-Release sign-offs and I would need the updated feature in Beta next week
> so that I can test it in time.

There's no need to keep it on the radar for a full-scale rollout on release in 64, but again, there will be a Shield study and we're still targeting a timely next release, e.g. in 65. Sorry for the confusion.