Closed Bug 1504205 Opened 2 years ago Closed 2 years ago
[Ubuntu] Bookmarking multiple tabs at once does not work via the CTRL+SHIFT+D keyboard shortcut
47 bytes, text/x-phabricator-request
|Details | Review|
[Affected versions]: - 65.0a1 (2018-11-02) - 64.0b6 - 63.0a1 (2018-07-05) [Affected platforms]: -Ubuntu 16.04 -Ubuntu 18.04 [Steps to reproduce]: 1. Open FF. 2. Open multiple tabs with various pages (ex: Facebook, Youtube, Reddit, IMDB etc) 3. Select all of the tabs. 4. Press CTRL+SHIFT+D [Expected result]: - The New bookmarks prompt is displayed and all the tabs are bookmarked after confirming the prompt. [Actual result]: - The New bookmarks prompt is not displayed and all the tabs cannot be bookmarked. [Regression range]: -This issue is not a regression. [Additional notes]: -This issue is not present on other platforms (Windows and macOS)
Jared, please prioritize. Thanks.
This is intentional and not supported in GTK per this comment, https://searchfox.org/mozilla-central/rev/6e0e603f4852b8e571e5b8ae133e772b18b6016e/browser/base/content/browser-sets.inc#234
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
(In reply to Jared Wein [:jaws] (Regression Engineering Owner for 65) (please needinfo? me) from comment #2) > This is intentional and not supported in GTK per this comment, > https://searchfox.org/mozilla-central/rev/ > 6e0e603f4852b8e571e5b8ae133e772b18b6016e/browser/base/content/browser-sets. > inc#234 Hmm, is this accurate and still up to date? Shift+Accel+D doesn't seem to do anything on Ubuntu 18.10. Also, we use Shift+Accel+A for about:addons, although that shortcut actually does something in multi-line text fields...
Status: RESOLVED → REOPENED
Component: Tabbed Browser → Keyboard Navigation
Resolution: WONTFIX → ---
Martin, do you know anything about the usage of Shift+Accel+D on GTK? Is this still reserved in some circumstances? See comment #2 and comment #3.
Flags: needinfo?(jaws) → needinfo?(stransky)
Control-Shift-D is used to open interactive debugger in gnome when Gtk+ debugging is enabled (https://wiki.gnome.org/Projects/GTK+/Inspector). Not sure how is that relevant for Firefox users and I'd say it's safe to use it in Firefox.
(In reply to Martin Stránský [:stransky] from comment #5) > Control-Shift-D is used to open interactive debugger in gnome when Gtk+ > debugging is enabled (https://wiki.gnome.org/Projects/GTK+/Inspector). Not > sure how is that relevant for Firefox users and I'd say it's safe to use it > in Firefox. Ahh, I see the shortcut can be blocked on Gtk+ level...so better don't use that as it depends on actual enabled/disabled debug state of Gtk+ library.
Well, it seems that if we enable this shortcut and it gets blocked, users aren't worse off than we are now, while users who haven't enabled GtkInspector would benefit.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/2d349c077a2a Enable Ctrl+Shift+D shortcut on Linux. r=stransky
Did you want to let this ride the trains?
Hello all, Confirming as verified fixed on the Nightly 65.0a1(2018-11-22). Verified on Ubuntu 16.04x64.
You need to log in before you can comment on or make changes to this bug.