1504220 - Lower the amount of includes for FrameMetrics.h

Status: RESOLVED FIXED

(Core :: Panning and Zooming, enhancement, P3)

Description

[Ryan Hunt [:rhunt]]

Touching this file can cause very long rebuild times. I don't think most includes are necessary for it.

Comment 1

[Ryan Hunt [:rhunt]]

Attachment: Bug 1504220 - Fix poorly written conditional in AsyncPanZoomController. r?botond

I added this condition in the relative scroll update patches, but had
meant to clean it up to be idiomatic C++ and forgot to.

Comment 2

[Ryan Hunt [:rhunt]]

Attachment: Bug 1504220 - Move ScrollableLayerGuid, ViewID, ZoomConstraints from FrameMetrics.h r?botond

This commit attempts to lower the pain of modifying FrameMetrics.h.

It looks like most includes really only want ViewID or
ScrollableLayerGuid, so this commit factors them out into a separate
header. In the process FrameMetrics::ViewID is changed to
ScrollableLayerGuid::ViewID, which personally seems like a better
place for it now that we have RepaintRequest. Unfortunately that
requires a lot of places to be updated.

After this commit there are still a couple of major places that
FrameMetrics is included.
 * nsDisplayList.h
 * nsIScrollableFrame.h
 * Layers.h

Those are going to be more tricky or impossible to fix so they're
not in this commit.

Comment 3

[Ryan Hunt [:rhunt]]

Here's a try run proving that this patch compiled :)

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=d94df781fdf088c09cb849407e05c023ff3c8484

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b2b796345807
Fix poorly written conditional in AsyncPanZoomController. r=botond
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad0782d7c503
Move ScrollableLayerGuid, ViewID, ZoomConstraints from FrameMetrics.h r=botond

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/b2b796345807
https://hg.mozilla.org/mozilla-central/rev/ad0782d7c503