1504244 - MSI installer using EXTRACT_DIR configuration doesn't extract, it just installs

Status: RESOLVED FIXED

(Firefox :: Installer, defect, P1)

Description

[Adrian Florinescu [:aflorinescu] [PTO until Aug 26]]]

[Description:]
Application files extraction directory - /EXTRACT_DIR=[directory]
Extract the application files to the given directory and exit, without actually running the installer. Of course, this means all other options will be ignored.

[Environment:]
Windows 8.1 x64

[STR:]
1. Run Orca.exe
2. File/Open and select the MSI to be edited. (e.g. : https://queue.taskcluster.net/v1/task/AhSb00lJSCiL-o0XJjqPzw/runs/0/artifacts/public/build/target.installer.msi)
3. Find the Property table and select it.
4. For the EXTRACT_DIR modify the value to something like C:\some_random_directory_to_extract and focus away.
5. Save the configured MSI.
6. Run the above configured MSI with: msiexec.exe /i "c:\MSi\EXTRACT_DIR.msi" /lvx "C:\msi\install.log"

[Actual Result:]
Firefox is installed in the default location

[Expected Result:]
Firefox is extracted to the specified location, in the STR case: C:\some_random_directory_to_extract

Comment 1

[Molly Howell (she/her) (mostly inactive)]

I see what's wrong here, the custom action for ExtractDir shouldn't have included /S on its command line. I can patch this as soon as bug 1485228 lands.

Comment 2

[Molly Howell (she/her) (mostly inactive)]

Attachment: Patch

I still have no idea who I can get to review changes to this file long-term, but this particular patch only touches one of the full installer command line strings, so Adam is qualified.

Comment 3

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Comment on attachment 9024043 [details] [diff] [review]
Patch

Looks like this should fix it in the msi, but it seems like the root issue is that /ExtractDir only works if it is the first switch (possibly after -y) [1]. It could be helpful to note in FullConfig.rst that it should be the only switch.

[1] https://searchfox.org/mozilla-central/rev/a3894a4dcfb5d42f2e6eee6cb9faf7141879ef1a/other-licenses/7zstub/src/CPP/7zip/Bundles/SFXSetup/SfxSetup.cpp#373

Comment 4

[Molly Howell (she/her) (mostly inactive)]

Attachment: Patch revision 1

Added a note to the documentation as suggested; carrying over r+.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8aa9b03d67b8
Remove an erroneous parameter that's overriding /ExtractDir in the MSI installer. r=agashlin

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8aa9b03d67b8