Closed Bug 1504283 Opened 6 years ago Closed 6 years ago

reviewbot gives bad advice for macros where an argument goes in a template parameter

Categories

(Developer Infrastructure :: Source Code Analysis, enhancement, P2)

Product:
Developer Infrastructure
Component:
Source Code Analysis
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: keeler, Assigned: andi)

References

(Blocks 1 open bug)

Details

reviewbot gave me this on https://phabricator.services.mozilla.com/D9969, which if you follow its advice, results in invalid C++: Warning: Macro argument should be enclosed in parentheses [clang-tidy: bugprone-macro-parentheses] #define SCOPED(x) typedef std::unique_ptr<x, ScopedMaybeDelete<x>> Scoped##x ^~~ ()
Assignee: nobody → bpostelnicu
Blocks: clang-based-analysis
Priority: -- → P2

This has been fixed once we've migrated to clang 8 infra.

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.