1504334 - Ship Intl.RelativeTimeFormat

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, enhancement)

Description

[André Bargull [:anba]]

Intl.RelativeTimeFormat is already used internally (through MozIntl) and we didn't find any blocking issues which may prevent exposing the new object to normal web users. 

Support for Intl.RelativeTimeFormat.prototype.formatToParts will land at a later time (bug 1473229).

Comment 1

[André Bargull [:anba]]

Attachment: bug1504334.patch

Updated step numbers in js/src/builtin/intl/RelativeTimeFormat.js and some additional minor changes to reflect the latest proposal updates. The rest of the patch is mostly enabling Intl.RelativeTimeFormat by default and removing the conditional support through |js::AddRelativeTimeFormatConstructor|.

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 9022290 [details] [diff] [review]
bug1504334.patch

Review of attachment 9022290 [details] [diff] [review]:
-----------------------------------------------------------------

hell yeah! Thank you Andrew!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/69b08ee5925d
Let Intl.RelativeTimeFormat ride the trains.  r=jwalden, r=gandalf

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/69b08ee5925d

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Hi Florian, can you help me promote this on MDN? This API got some recent traction because we and V8 exposed it, and I'd love to link people to MDN rather than any other sources ;)

Comment 6

[Chris Mills [:cmills]]

Hi Zibi,

Sorry for not being more responsive on this. I just added a note to the Fx65 rel notes for cover this addition:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/65#JavaScript

And one of our contributors added this page:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RelativeTimeFormat

We still need to make sure this is linked up properly, e.g. in places like
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl

I'll try to get to these final checks in the next few days, before breaking up for Xmas vacation.

Comment 7

[Florian Scholz (Open Web Docs)]

LGTM Chris. Remaining doc work is also tracked here now: https://github.com/tc39/proposal-intl-relative-time/issues/102