1504336 - Intermittent dom/media/tests/mochitest/test_peerConnection_simulcastOddResolution.html | Width 640 should be within 10% of 1280 for rid 'foo'

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P3)

Description

[Treeherder Bug Filer]

Filed by: csabou [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=209505291&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/crkqBhj4SwujmsMWxGS9DQ/runs/0/artifacts/public/logs/live_backing.log

[task 2018-11-02T20:28:08.260Z] 20:28:08     INFO - TEST-PASS | dom/media/tests/mochitest/test_peerConnection_simulcastOddResolution.html | We have exactly one RTP receiver 
[task 2018-11-02T20:28:08.261Z] 20:28:08     INFO - element _remote_{707ab9f3-d5ec-448b-8dde-bc7178392c26} resized to 640x352
[task 2018-11-02T20:28:08.262Z] 20:28:08     INFO - Source resolution is 1280x720
[task 2018-11-02T20:28:08.264Z] 20:28:08     INFO - Buffered messages finished
[task 2018-11-02T20:28:08.266Z] 20:28:08     INFO - TEST-UNEXPECTED-FAIL | dom/media/tests/mochitest/test_peerConnection_simulcastOddResolution.html | Width 640 should be within 10% of 1280 for rid 'foo' 
[task 2018-11-02T20:28:08.267Z] 20:28:08     INFO -     SimpleTest.ok@SimpleTest/SimpleTest.js:275:7
[task 2018-11-02T20:28:08.268Z] 20:28:08     INFO -     checkResolution@dom/media/tests/mochitest/test_peerConnection_simulcastOddResolution.html:68:5
[task 2018-11-02T20:28:08.270Z] 20:28:08     INFO -     async*checkResolutions@dom/media/tests/mochitest/test_peerConnection_simulcastOddResolution.html:84:11
[task 2018-11-02T20:28:08.272Z] 20:28:08     INFO -     async*PC_LOCAL_CHANGE_PARAMS_2@dom/media/tests/mochitest/test_peerConnection_simulcastOddResolution.html:176:15
[task 2018-11-02T20:28:08.273Z] 20:28:08     INFO -     async*execute/</<@dom/media/tests/mochitest/head.js:849:31
[task 2018-11-02T20:28:08.275Z] 20:28:08     INFO -     promise callback*execute/<@dom/media/tests/mochitest/head.js:847:14
[task 2018-11-02T20:28:08.277Z] 20:28:08     INFO -     execute@dom/media/tests/mochitest/head.js:842:12
[task 2018-11-02T20:28:08.278Z] 20:28:08     INFO -     PeerConnectionTest.prototype.run@dom/media/tests/mochitest/pc.js:486:10
[task 2018-11-02T20:28:08.279Z] 20:28:08     INFO -     @dom/media/tests/mochitest/test_peerConnection_simulcastOddResolution.html:180:11
[task 2018-11-02T20:28:08.281Z] 20:28:08     INFO -     async*runNetworkTest/<@dom/media/tests/mochitest/pc.js:2211:13
[task 2018-11-02T20:28:08.282Z] 20:28:08     INFO -     async*runTestWhenReady/<@dom/media/tests/mochitest/head.js:470:41
[task 2018-11-02T20:28:08.284Z] 20:28:08     INFO -     promise callback*runTestWhenReady@dom/media/tests/mochitest/head.js:470:10
[task 2018-11-02T20:28:08.285Z] 20:28:08     INFO -     runNetworkTest@dom/media/tests/mochitest/pc.js:2193:9
[task 2018-11-02T20:28:08.287Z] 20:28:08     INFO -     async*@dom/media/tests/mochitest/test_peerConnection_simulcastOddResolution.html:89:3
[task 2018-11-02T20:28:08.288Z] 20:28:08     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-11-02T20:28:08.290Z] 20:28:08     INFO - TEST-UNEXPECTED-FAIL | dom/media/tests/mochitest/test_peerConnection_simulcastOddResolution.html | Height 352 should be within 10% of 720 for rid 'foo' 
[task 2018-11-02T20:28:08.292Z] 20:28:08     INFO -     SimpleTest.ok@SimpleTest/SimpleTest.js:275:7
[task 2018-11-02T20:28:08.293Z] 20:28:08     INFO -     checkResolution@dom/media/tests/mochitest/test_peerConnection_simulcastOddResolution.html:70:5
[task 2018-11-02T20:28:08.295Z] 20:28:08     INFO -     async*checkResolutions@dom/media/tests/mochitest/test_peerConnection_simulcastOddResolution.html:84:11
[task 2018-11-02T20:28:08.296Z] 20:28:08     INFO -     async*PC_LOCAL_CHANGE_PARAMS_2@dom/media/tests/mochitest/test_peerConnection_simulcastOddResolution.html:176:15
[task 2018-11-02T20:28:08.298Z] 20:28:08     INFO -     async*execute/</<@dom/media/tests/mochitest/head.js:849:31
[task 2018-11-02T20:28:08.299Z] 20:28:08     INFO -     promise callback*execute/<@dom/media/tests/mochitest/head.js:847:14
[task 2018-11-02T20:28:08.300Z] 20:28:08     INFO -     execute@dom/media/tests/mochitest/head.js:842:12
[task 2018-11-02T20:28:08.302Z] 20:28:08     INFO -     PeerConnectionTest.prototype.run@dom/media/tests/mochitest/pc.js:486:10
[task 2018-11-02T20:28:08.303Z] 20:28:08     INFO -     @dom/media/tests/mochitest/test_peerConnection_simulcastOddResolution.html:180:11
[task 2018-11-02T20:28:08.304Z] 20:28:08     INFO -     async*runNetworkTest/<@dom/media/tests/mochitest/pc.js:2211:13
[task 2018-11-02T20:28:08.306Z] 20:28:08     INFO -     async*runTestWhenReady/<@dom/media/tests/mochitest/head.js:470:41
[task 2018-11-02T20:28:08.307Z] 20:28:08     INFO -     promise callback*runTestWhenReady@dom/media/tests/mochitest/head.js:470:10
[task 2018-11-02T20:28:08.308Z] 20:28:08     INFO -     runNetworkTest@dom/media/tests/mochitest/pc.js:2193:9
[task 2018-11-02T20:28:08.310Z] 20:28:08     INFO -     async*@dom/media/tests/mochitest/test_peerConnection_simulcastOddResolution.html:89:3
[task 2018-11-02T20:28:08.312Z] 20:28:08     INFO - Changing to rid bar

Comment 1

[Intermittent Failures Robot]

1 failures in 2978 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 1

Platform breakdown:
* linux64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1504336&startday=2018-10-29&endday=2018-11-04&tree=all

Comment 2

[Intermittent Failures Robot]

2 failures in 3007 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 1
* mozilla-central: 1

Platform breakdown:
* linux64: 1
* linux32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1504336&startday=2018-11-05&endday=2018-11-11&tree=all

Comment 3

[Intermittent Failures Robot]

8 failures in 2917 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-central: 2
* autoland: 2
* mozilla-inbound: 4

Platform breakdown:
* linux32: 1
* linux64-qr: 2
* linux64: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1504336&startday=2018-11-12&endday=2018-11-18&tree=all

Comment 4

[Intermittent Failures Robot]

20 failures in 2387 pushes (0.008 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 4
* autoland: 5
* try: 10
* mozilla-central: 1

Platform breakdown:
* linux32: 5
* linux64-qr: 10
* osx-10-10: 1
* linux64: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1504336&startday=2018-11-19&endday=2018-11-25&tree=all

Comment 5

[Intermittent Failures Robot]

3 failures in 2808 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* try: 1
* mozilla-central: 1
* autoland: 1

Platform breakdown:
* linux32: 1
* osx-10-10: 1
* linux64-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1504336&startday=2018-11-26&endday=2018-12-02&tree=all

Comment 6

[Intermittent Failures Robot]

7 failures in 1862 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-central: 2
* mozilla-inbound: 2
* mozilla-beta: 1
* autoland: 2

Platform breakdown:
* linux64: 2
* osx-10-10: 1
* linux64-qr: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1504336&startday=2018-12-03&endday=2018-12-09&tree=all

Comment 7

[Intermittent Failures Robot]

5 failures in 2485 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 1
* mozilla-inbound: 3
* mozilla-beta: 1

Platform breakdown:
* osx-10-10: 2
* linux64-qr: 1
* linux64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1504336&startday=2018-12-10&endday=2018-12-16&tree=all

Comment 8

[Intermittent Failures Robot]

5 failures in 2648 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-central: 2
* mozilla-beta: 1
* autoland: 2

Platform breakdown:
* linux64: 1
* osx-10-10: 1
* linux32-nightly: 1
* linux64-qr: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1504336&startday=2018-12-17&endday=2018-12-23&tree=all

Comment 9

[Intermittent Failures Robot]

3 failures in 1008 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 2
* autoland: 1

Platform breakdown:
* linux64: 1
* linux32: 1
* linux64-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1504336&startday=2018-12-24&endday=2018-12-30&tree=all

Comment 10

[Intermittent Failures Robot]

4 failures in 1668 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 1
* autoland: 2
* try: 1

Platform breakdown:
* linux64: 1
* linux64-qr: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1504336&startday=2018-12-31&endday=2019-01-06&tree=all

Comment 11

[Intermittent Failures Robot]

7 failures in 2627 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 3
• mozilla-beta: 1
• mozilla-central: 2
• mozilla-inbound: 1

Platform breakdown:

• osx-10-10: 3
• linux64-qr: 3
• linux64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1504336&startday=2019-01-07&endday=2019-01-13&tree=all

Comment 12

[Intermittent Failures Robot]

11 failures in 2378 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 3
• mozilla-beta: 2
• try: 1
• mozilla-inbound: 1
• mozilla-central: 4

Platform breakdown:

• linux64-qr: 4
• linux32-nightly: 2
• linux64: 4
• osx-10-10: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1504336&startday=2019-01-14&endday=2019-01-20&tree=all

Comment 13

[Intermittent Failures Robot]

6 failures in 2383 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-inbound: 1
• mozilla-central: 1
• autoland: 4

Platform breakdown:

• linux64: 1
• linux32: 1
• osx-10-10: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1504336&startday=2019-01-21&endday=2019-01-27&tree=all

Comment 14

[Intermittent Failures Robot]

2 failures in 2628 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-inbound: 1
• mozilla-central: 1

Platform breakdown:

• linux64-qr: 1
• osx-10-10: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1504336&startday=2019-01-28&endday=2019-02-03&tree=all

Comment 15

[Intermittent Failures Robot]

3 failures in 2658 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 2
• mozilla-inbound: 1

Platform breakdown:

• osx-10-10: 1
• linux64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1504336&startday=2019-02-04&endday=2019-02-10&tree=all

Comment 16

[Intermittent Failures Robot]

4 failures in 2832 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1
• try: 1
• mozilla-beta: 1
• mozilla-inbound: 1

Platform breakdown:

• linux64-qr: 2
• linux32-nightly: 1
• osx-10-10: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1504336&startday=2019-02-11&endday=2019-02-17&tree=all

Comment 17

[Intermittent Failures Robot]

6 failures in 2602 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 5
• mozilla-beta: 1

Platform breakdown:

• linux32: 1
• linux64-qr: 1
• linux64-pgo-qr: 1
• linux64: 2
• osx-10-10: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1504336&startday=2019-02-18&endday=2019-02-24&tree=all

Comment 18

[Intermittent Failures Robot]

32 failures in 2981 pushes (0.011 failures/push) were associated with this bug in the last 7 days.

This is the #47 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• mozilla-beta: 1
• mozilla-inbound: 8
• autoland: 18
• mozilla-central: 1
• try: 4

Platform breakdown:

• osx-10-10: 5
• linux32: 1
• linux64-pgo-qr: 17
• linux64: 6
• linux64-qr: 2
• linux64-nightly: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1504336&startday=2019-02-25&endday=2019-03-03&tree=all

Comment 19

[Intermittent Failures Robot]

37 failures in 2818 pushes (0.013 failures/push) were associated with this bug in the last 7 days.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 33
• mozilla-beta: 1
• mozilla-inbound: 2
• try: 1

Platform breakdown:

• linux32: 2
• linux64: 9
• linux64-pgo-qr: 25
• linux64-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1504336&startday=2019-03-04&endday=2019-03-10&tree=all

Comment 20

[Intermittent Failures Robot]

18 failures in 2771 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-inbound: 7
• mozilla-central: 5
• autoland: 6

Platform breakdown:

• linux64-pgo-qr: 10
• linux64-qr: 2
• linux64: 5
• linux32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1504336&startday=2019-03-11&endday=2019-03-17&tree=all

Comment 21

[Intermittent Failures Robot]

29 failures in 2561 pushes (0.011 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 13
• mozilla-central: 5
• try: 4
• mozilla-beta: 5
• mozilla-inbound: 2

Platform breakdown:

• osx-10-10: 6
• linux64-qr: 2
• linux64-pgo-qr: 10
• linux32: 5
• linux64: 3
• linux32-devedition: 1
• linux64-devedition: 1
• linux32-nightly: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1504336&startday=2019-03-18&endday=2019-03-24&tree=all

Comment 22

[Andreas Pehrson [:pehrsons]]

This happens because sending frames through the VideoFrameConverter [1] is async, and thus this test becomes racy after setParameters when listening for a resize event. We expect the resize to come from switching to rid 'bar', but we don't verify the size of it. It is instead coming from setParameters, because the scaling factor for the already-selected rid 'baz' changed.

This means the next time we're waiting for resize, we're expecting it from switching to rid 'foo', thus being 1280x720, but it is instead coming from the previous switch to rid 'bar', being 640x352.

This wouldn't be a problem if [1] was sync, because no frames are emitted as setParameters is called.

A simple fix in the test is to explicitly emit frames and wait for a resize after setParameters.

[1] https://searchfox.org/mozilla-central/rev/2c912888e3b7ae4baf161d98d7a01434f31830aa/dom/media/VideoFrameConverter.h#95,231

Comment 23

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1504336 - Avoid race in test_pc_simulcastOddResolution.html. r?jib

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb2781c15ef3
Avoid race in test_pc_simulcastOddResolution.html. r=jib

Comment 25

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/eb2781c15ef3

Comment 26

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8f40010937b5

Comment 27

[Intermittent Failures Robot]

15 failures in 3910 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 5
• autoland: 3
• mozilla-inbound: 4
• try: 1
• mozilla-central: 2

Platform breakdown:

• linux64-nightly: 2
• osx-10-10: 5
• linux64-pgo-qr: 4
• linux64: 2
• linux64-qr: 1
• linux32-devedition: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1504336&startday=2019-03-25&endday=2019-03-31&tree=all