1504522 - Remove gBrowser.serializationHelper getter

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement, P3)

Description

[Dão Gottwald [:dao]]

This appears to be unused:

https://searchfox.org/mozilla-central/rev/7c0a5e2aefd29b5b56923bc9fbc1180fc488b33c/browser/base/content/tabbrowser.js#26-29

Comment 1

[r2hkri]

Hello, I would like to try to fix this. 

Is it as simple as removing the aforementioned lines? And how would testing work?

I have already built Firefox (non artifact version on Linux) so my guess is that I would just try `./mach run` and see if everything still works.

Thanks!

Comment 2

[r2hkri]

Attachment: Bug 1504522 - Remove gBrowser.serializationHelper getter because it's unused

Comment 3

[Dão Gottwald [:dao]]

(In reply to r2hkri from comment #1)
> Hello, I would like to try to fix this. 
> 
> Is it as simple as removing the aforementioned lines?

Yep.

> And how would testing work?
> 
> I have already built Firefox (non artifact version on Linux) so my guess is
> that I would just try `./mach run` and see if everything still works.

Yeah, that's good enough in this case.

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de9cc5033d87
Remove gBrowser.serializationHelper getter because it's unused r=dao

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/de9cc5033d87