Closed
Bug 1504522
Opened 6 years ago
Closed 6 years ago
Remove gBrowser.serializationHelper getter
Categories
(Firefox :: Tabbed Browser, enhancement, P3)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: dao, Assigned: r2hkri, Mentored)
Details
(Keywords: good-first-bug, Whiteboard: [lang=js])
Attachments
(1 file)
This appears to be unused: https://searchfox.org/mozilla-central/rev/7c0a5e2aefd29b5b56923bc9fbc1180fc488b33c/browser/base/content/tabbrowser.js#26-29
Hello, I would like to try to fix this. Is it as simple as removing the aforementioned lines? And how would testing work? I have already built Firefox (non artifact version on Linux) so my guess is that I would just try `./mach run` and see if everything still works. Thanks!
|
Reporter | |
Comment 3•6 years ago
|
||
(In reply to r2hkri from comment #1) > Hello, I would like to try to fix this. > > Is it as simple as removing the aforementioned lines? Yep. > And how would testing work? > > I have already built Firefox (non artifact version on Linux) so my guess is > that I would just try `./mach run` and see if everything still works. Yeah, that's good enough in this case. Thanks!
Assignee: nobody → r2hkri
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/de9cc5033d87 Remove gBrowser.serializationHelper getter because it's unused r=dao
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/de9cc5033d87
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in
before you can comment on or make changes to this bug.
Description
•