Closed Bug 1504523 Opened 3 years ago Closed 3 years ago

browser_UrlbarInput_overflow.js: Use String repeat() method

Categories

(Firefox :: Address Bar, enhancement, P5)

Product:
Firefox
Component:
Address Bar
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: dao, Assigned: rishabhjairath, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [lang=js])

Attachments

(1 file)

Bug 1504523 - Use String repeat() method in browser_UrlbarInput_overflow.js
47 bytes, text/x-phabricator-request
Details | Review 
Hi Dao,
I am a newbie with one contribution. Can I take up this issue?
(In reply to rishabhjairath from comment #1)
> Hi Dao,
> I am a newbie with one contribution. Can I take up this issue?

Sure... Let me know if you have questions.
Assignee: nobody → rishabhjairath
(In reply to Dão Gottwald [::dao] from comment #2)
> (In reply to rishabhjairath from comment #1)
> > Hi Dao,
> > I am a newbie with one contribution. Can I take up this issue?
> 
> Sure... Let me know if you have questions.

I have pulled the latest changes. But in "browser/components/urlbar/tests" I only have one folder named "unit". How can I get the "browser" folder in tests?
(In reply to rishabhjairath from comment #3)
> (In reply to Dão Gottwald [::dao] from comment #2)
> > (In reply to rishabhjairath from comment #1)
> > > Hi Dao,
> > > I am a newbie with one contribution. Can I take up this issue?
> > 
> > Sure... Let me know if you have questions.
> 
> I have pulled the latest changes. But in "browser/components/urlbar/tests" I
> only have one folder named "unit". How can I get the "browser" folder in
> tests?

It should be there in the tests folder. It's an ordinary folder, no idea why it wouldn't be there in your case...
Hi Dao,
could you review my changes please?

https://phabricator.services.mozilla.com/D11925
Attachment #9025362 - Attachment description: Bug 1504523 - used String repeat() method in browser browser_UrlbarInput_overflow.js → Bug 1504523 - Use String repeat() method in browser_UrlbarInput_overflow.js
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4cfa567d7380
Use String repeat() method in browser_UrlbarInput_overflow.js r=dao
https://hg.mozilla.org/mozilla-central/rev/4cfa567d7380
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.