1504523 - browser_UrlbarInput_overflow.js: Use String repeat() method

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P5)

Description

[Dão Gottwald [:dao]]

new Array(200).fill("%20").join("") can be simplified to "%20".repeat(200):

https://searchfox.org/mozilla-central/rev/7c0a5e2aefd29b5b56923bc9fbc1180fc488b33c/browser/components/urlbar/tests/browser/browser_UrlbarInput_overflow.js#53

Comment 1

[rishabhjairath]

Hi Dao,
I am a newbie with one contribution. Can I take up this issue?

Comment 2

[Dão Gottwald [:dao]]

(In reply to rishabhjairath from comment #1)
> Hi Dao,
> I am a newbie with one contribution. Can I take up this issue?

Sure... Let me know if you have questions.

Comment 3

[rishabhjairath]

(In reply to Dão Gottwald [::dao] from comment #2)
> (In reply to rishabhjairath from comment #1)
> > Hi Dao,
> > I am a newbie with one contribution. Can I take up this issue?
> 
> Sure... Let me know if you have questions.

I have pulled the latest changes. But in "browser/components/urlbar/tests" I only have one folder named "unit". How can I get the "browser" folder in tests?

Comment 4

[Dão Gottwald [:dao]]

(In reply to rishabhjairath from comment #3)
> (In reply to Dão Gottwald [::dao] from comment #2)
> > (In reply to rishabhjairath from comment #1)
> > > Hi Dao,
> > > I am a newbie with one contribution. Can I take up this issue?
> > 
> > Sure... Let me know if you have questions.
> 
> I have pulled the latest changes. But in "browser/components/urlbar/tests" I
> only have one folder named "unit". How can I get the "browser" folder in
> tests?

It should be there in the tests folder. It's an ordinary folder, no idea why it wouldn't be there in your case...

Comment 5

[rishabhjairath]

Hi Dao,
could you review my changes please?

https://phabricator.services.mozilla.com/D11925

Comment 6

[rishabhjairath]

Attachment: Bug 1504523 - Use String repeat() method in browser_UrlbarInput_overflow.js

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4cfa567d7380
Use String repeat() method in browser_UrlbarInput_overflow.js r=dao

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/4cfa567d7380