Closed Bug 1504536 Opened Last year Closed Last year

Shrink animated_properties.mako.rs

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(7 files)

It's very big without a reason to. Most of the properties should be moved to its own rust files.

In these patches I move most of them, except transform and filter (which use mako still), and cleanup the SVG ones which are terribly complicated without a reason to.
There are better ways, plus the existing code didn't handle aliases at
all (not that it needed to, but it's better if it does).
Doesn't really need to be in a mako file.
Similarly, the code is not trivial and doesn't really need to be in
mako.
Being in mako is unnecessary, and makes it harder to debug and such.
It's overly generic for no good reason.
Priority: -- → P3
I think Hiro has already picked up some (all?) of these reviews. I'm off sick today (and maybe tomorrow) so please bear with me if you specifically need any reviews from me.
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/df3738e12c61
Move shorthand IDL order stuff out of animated_properties. r=hiro
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/0f270a54b160
Move the keyframes property priority stuff outside of animated_properties. r=hiro
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/2d0e45f37f45
Move various length animation implementations to its own file. r=hiro
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/7285bb78cbcf
Move various font-related animation code to its own file. r=hiro
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/6884ba750aa3
Remove nscsspropertyid_is_{animatable,transitionable}. r=hiro
https://hg.mozilla.org/integration/autoland/rev/42257c17ab37
Move animation of svg-related bits outside of animated_properties. r=hiro
https://hg.mozilla.org/integration/autoland/rev/6251012862a2
Simplify the SVG animation code. r=hiro,heycam
Depends on: 1514086
Regressions: 1536688
No longer regressions: 1536688
You need to log in before you can comment on or make changes to this bug.