Closed
Bug 1504536
Opened 6 years ago
Closed 6 years ago
Shrink animated_properties.mako.rs
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(7 files)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
It's very big without a reason to. Most of the properties should be moved to its own rust files. In these patches I move most of them, except transform and filter (which use mako still), and cleanup the SVG ones which are terribly complicated without a reason to.
Assignee | ||
Comment 1•6 years ago
|
||
There are better ways, plus the existing code didn't handle aliases at all (not that it needed to, but it's better if it does).
Assignee | ||
Comment 2•6 years ago
|
||
Doesn't really need to be in a mako file.
Assignee | ||
Comment 3•6 years ago
|
||
Similarly, no need to be here.
Assignee | ||
Comment 4•6 years ago
|
||
It's nicer, I think.
Assignee | ||
Comment 5•6 years ago
|
||
Similarly, the code is not trivial and doesn't really need to be in mako.
Assignee | ||
Comment 6•6 years ago
|
||
Being in mako is unnecessary, and makes it harder to debug and such.
Assignee | ||
Comment 7•6 years ago
|
||
It's overly generic for no good reason.
Updated•6 years ago
|
Priority: -- → P3
Comment 8•6 years ago
|
||
I think Hiro has already picked up some (all?) of these reviews. I'm off sick today (and maybe tomorrow) so please bear with me if you specifically need any reviews from me.
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/df3738e12c61 Move shorthand IDL order stuff out of animated_properties. r=hiro
Comment 10•6 years ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/0f270a54b160 Move the keyframes property priority stuff outside of animated_properties. r=hiro
Comment 11•6 years ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/2d0e45f37f45 Move various length animation implementations to its own file. r=hiro
Comment 12•6 years ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/7285bb78cbcf Move various font-related animation code to its own file. r=hiro
Comment 13•6 years ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/6884ba750aa3 Remove nscsspropertyid_is_{animatable,transitionable}. r=hiro https://hg.mozilla.org/integration/autoland/rev/42257c17ab37 Move animation of svg-related bits outside of animated_properties. r=hiro https://hg.mozilla.org/integration/autoland/rev/6251012862a2 Simplify the SVG animation code. r=hiro,heycam
Comment 14•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/df3738e12c61 https://hg.mozilla.org/mozilla-central/rev/0f270a54b160 https://hg.mozilla.org/mozilla-central/rev/2d0e45f37f45 https://hg.mozilla.org/mozilla-central/rev/7285bb78cbcf https://hg.mozilla.org/mozilla-central/rev/6884ba750aa3 https://hg.mozilla.org/mozilla-central/rev/42257c17ab37 https://hg.mozilla.org/mozilla-central/rev/6251012862a2
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•