1504536 - Shrink animated_properties.mako.rs

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

It's very big without a reason to. Most of the properties should be moved to its own rust files.

In these patches I move most of them, except transform and filter (which use mako still), and cleanup the SVG ones which are terribly complicated without a reason to.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1504536 - Remove nscsspropertyid_is_{animatable,transitionable}.

There are better ways, plus the existing code didn't handle aliases at
all (not that it needed to, but it's better if it does).

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1504536 - Move shorthand IDL order stuff out of animated_properties.

Doesn't really need to be in a mako file.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1504536 - Move the keyframes property priority stuff outside of animated_properties.

Similarly, no need to be here.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1504536 - Move various length animation implementations to its own file.

It's nicer, I think.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1504536 - Move various font-related animation code to its own file.

Similarly, the code is not trivial and doesn't really need to be in
mako.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1504536 - Move animation of svg-related bits outside of animated_properties.

Being in mako is unnecessary, and makes it harder to debug and such.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1504536 - Simplify the SVG animation code.

It's overly generic for no good reason.

Comment 8

[Brian Birtles (:birtles, Feb 26~ parental leave)]

I think Hiro has already picked up some (all?) of these reviews. I'm off sick today (and maybe tomorrow) so please bear with me if you specifically need any reviews from me.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df3738e12c61
Move shorthand IDL order stuff out of animated_properties. r=hiro

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f270a54b160
Move the keyframes property priority stuff outside of animated_properties. r=hiro

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d0e45f37f45
Move various length animation implementations to its own file. r=hiro

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7285bb78cbcf
Move various font-related animation code to its own file. r=hiro

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6884ba750aa3
Remove nscsspropertyid_is_{animatable,transitionable}. r=hiro
https://hg.mozilla.org/integration/autoland/rev/42257c17ab37
Move animation of svg-related bits outside of animated_properties. r=hiro
https://hg.mozilla.org/integration/autoland/rev/6251012862a2
Simplify the SVG animation code. r=hiro,heycam

Comment 14

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/df3738e12c61
https://hg.mozilla.org/mozilla-central/rev/0f270a54b160
https://hg.mozilla.org/mozilla-central/rev/2d0e45f37f45
https://hg.mozilla.org/mozilla-central/rev/7285bb78cbcf
https://hg.mozilla.org/mozilla-central/rev/6884ba750aa3
https://hg.mozilla.org/mozilla-central/rev/42257c17ab37
https://hg.mozilla.org/mozilla-central/rev/6251012862a2