Closed Bug 1504614 Opened 7 years ago Closed 3 years ago

Can we make BinTokenReaderBase or BinTokenReaderMultipart a subclass of ErrorReporter ?

Categories

(Core :: JavaScript Engine, enhancement, P3)

Product:
Core
Component:
JavaScript Engine
Type:
enhancement

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: arai, Unassigned)

References

Details

To have similar mechanism of error reporting between regular parser and BinAST parser, moving ErrorReporter to tokenizer part in BinAST will reduce the difference. (I'm not sure if we can actually share the code between regular parser and BinAST parser, because of class hierarchy issue, but at lease we can have more similar code, which will reduce the maintenance burden)
this actually doesn't block bug 1502792. it might be possible to implement this based on bug 1502792 patch.
No longer blocks: 1502792
Depends on: 1502792
Assignee: arai.unmht → nobody
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.