1504634 - Add tooltip message for refresh button in Storage Inspector section

Status: VERIFIED FIXED

Description

[Cristian Fogel, QA [:cfogel]]

Attachment: devTools_storageInspector_RefreshIconTooltip.png

[Affected versions]:
- 60.3.0esr , 63.0.1, 64.0b6, 65.0a1 (2018-11-04) 

[Affected platforms]:
- Win10, macOS10.13, 

[Steps to reproduce]:
1. Launch Firefox, access any webpage;
2. Open devTools - Storage Inspector tab;
3. Hover over the Refresh button in the inspector section;

[Expected result]:
- tooltip is displayed;

[Actual result]:
- no tooltip displayed;

[Regression range]:
- not a regression, the refresh button seems to not have a tooltip added from the start;
- pre-implementation: 2017-08-30;
- post-implementation: 2017-08-31;

Comment 1

[Shivam Singhal [ :championshuttler ]]

Hi Mike , I would like to work on it , can you help me getting started!?

Thanks

Comment 2

[Rainier Go [:rfgo]]

Hi Cristi and Mike,

Since the bug was still on here, I went ahead and tried to tackle it. I've attached a screenshot below and wanted to request a code review.

Thanks.

https://pasteboard.co/I1Mqxpw.png

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

@Rainier That looks great... can you attach the patch?

Comment 4

[Rainier Go [:rfgo]]

Sounds good! Attached below:

https://phabricator.services.mozilla.com/D20207

Comment 5

[Rainier Go [:rfgo]]

Attachment: Bug 1504634 - Added tooltip to refresh button of storage inspector section. r=mikeratcliffe

Comment 6

[Rainier Go [:rfgo]]

Attachment: Bug 1504634 - Added tooltip to refresh button of storage inspector section. r=mikeratcliffe

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

@rainier r+... would you like me to land your patch for you?

Comment 8

[Rainier Go [:rfgo]]

Mike that would be great!

Comment 9

[Rainier Go [:rfgo]]

Since this is my first bug, just wanted to double check, in the future the mentors will be landing the patches right?

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b783af3efdd
Added tooltip to refresh button of storage inspector section. r=miker

Comment 11

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

I have queued it for landing, thanks for working on it!

(In reply to Rainier Go [:rfgo] from comment #9)

Since this is my first bug, just wanted to double check, in the future the mentors will be landing the patches right?

If you land lots of patches you can get permission to land things but for the moment it will be the mentors. You are best to ask them to land it for you because they may not know whether you have permission to land things yourself.

You can find more good first bugs here:
https://bugs.firefox-dev.tools/?easy&tool=all

Comment 12

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/9b783af3efdd

Comment 13

[Alexandru Trif, QA [:atrif]]

Confirmed the issue with Firefox 65.0a1 (2018-11-05) on Windows 10.
Fix verified with Firefox 67.0a1 (20190227163104), Windows 10 x64 and macOS 10.13.6.