Closed Bug 1504638 Opened 6 years ago Closed 6 years ago

Protect worker thread-private members of WorkerPrivate from access from other threads

Categories

(Core :: DOM: Service Workers, enhancement, P2)

Product:
Core
Component:
DOM: Service Workers
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: ytausky, Assigned: ytausky)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Put some of WorkerPrivate's members behind thread access guards
47 bytes, text/x-phabricator-request
Details | Review 
Some of WorkerPrivate's many data members are meant to be accessed from specific threads. Most of the time this is guaranteed (in the best case) by an assertion in each member function that accesses said members, and sometimes it's just documented in comments (which are unfortunately sometimes wrong).

Members which are only meant for the worker thread should be wrapped with some class that ensures they're only accessed by the intended thread.
Assignee: nobody → ytausky
Status: NEW → ASSIGNED
Priority: -- → P2
Keywords: checkin-needed
Pushed by rvandermeulen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fe76d83b9d4f
Put some of WorkerPrivate's members behind thread access guards r=asuth,baku,froydnj
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/fe76d83b9d4f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
See Also: → 1509725
Regressed by: 1633298
Keywords: regression
Regressions: 1687597
No longer regressions: 1687597
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: