1504638 - Protect worker thread-private members of WorkerPrivate from access from other threads

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, enhancement, P2)

Description

[Yaron Tausky [:ytausky]]

Some of WorkerPrivate's many data members are meant to be accessed from specific threads. Most of the time this is guaranteed (in the best case) by an assertion in each member function that accesses said members, and sometimes it's just documented in comments (which are unfortunately sometimes wrong).

Members which are only meant for the worker thread should be wrapped with some class that ensures they're only accessed by the intended thread.

Comment 1

[Yaron Tausky [:ytausky]]

Attachment: Put some of WorkerPrivate's members behind thread access guards

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe76d83b9d4f
Put some of WorkerPrivate's members behind thread access guards r=asuth,baku,froydnj

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/fe76d83b9d4f