Closed Bug 1504729 Opened 1 year ago Closed 1 year ago

Make sure the STATE_LOADED_TRACKING_CONTENT state is stored outside of the content blocking log

Categories

(Firefox :: Protections UI, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 65
Tracking Status
firefox65 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The new privacy UI is going to use the STATE_LOADED_TRACKING_CONTENT state to determine whether a third-party is a tracker or not.  Since the content blocking log imposes a maximum per-origin log length, storing STATE_LOADED_TRACKING_CONTENT in the log itself runs the risk of losing that state, so it is better to keep that state outside of the log array somewhere.
Note for Johann: I'm not going to change the JSON encoding of the log, so in the encoding it will still look as if the STATE_LOADED_TRACKING_CONTENT flag is recorded inside the log array...
Status: NEW → ASSIGNED
Priority: P2 → P1
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/971167f49931
Make sure the STATE_LOADED_TRACKING_CONTENT state is stored outside of the content blocking log r=baku
Backed out changeset 971167f49931 (Bug 1504729) for causing BR build bustages.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=971167f499310c3ea19830a1f34b5dd070c808f3

Backout link: https://hg.mozilla.org/integration/autoland/rev/2380a1a98a0e96557eb1713fe7d42abba9e7ccb6

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=210080823&repo=autoland&lineNumber=46053

[task 2018-11-06T14:44:31.775Z] 14:44:31     INFO -   17: 0x5663b1b3 - std::sys_common::thread::start_thread::h41f52f57057f5a12
[task 2018-11-06T14:44:31.775Z] 14:44:31     INFO -                        at liballoc/boxed.rs:656
[task 2018-11-06T14:44:31.775Z] 14:44:31     INFO -                        at libstd/sys_common/thread.rs:24
[task 2018-11-06T14:44:31.775Z] 14:44:31     INFO -   18: 0x5662c19b - std::sys::unix::thread::Thread::new::thread_start::hb75e7519dd7dc300
[task 2018-11-06T14:44:31.775Z] 14:44:31     INFO -                        at libstd/sys/unix/thread.rs:90
[task 2018-11-06T14:44:31.776Z] 14:44:31     INFO -   19: 0x55632953 - <unknown>
[task 2018-11-06T14:44:31.776Z] 14:44:31     INFO - failures:
[task 2018-11-06T14:44:31.776Z] 14:44:31     INFO -     bindings::root::__bindgen_test_layout_Pair_open0_bool__ContentBlockingLog_OriginLog_close0_instantiation
[task 2018-11-06T14:44:31.776Z] 14:44:31     INFO - test result: FAILED. 1046 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
[task 2018-11-06T14:44:31.776Z] 14:44:31     INFO - error: test failed, to rerun pass '--lib'
[task 2018-11-06T14:44:31.777Z] 14:44:31     INFO - /builds/worker/workspace/build/src/config/rules.mk:1069: recipe for target 'force-cargo-test-run' failed
[task 2018-11-06T14:44:31.777Z] 14:44:31     INFO - make[2]: *** [force-cargo-test-run] Error 101
[task 2018-11-06T14:44:31.777Z] 14:44:31     INFO - make[2]: Target 'check' not remade because of errors.
[task 2018-11-06T14:44:31.777Z] 14:44:31     INFO - make[2]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/library/rust'
[task 2018-11-06T14:44:31.777Z] 14:44:31     INFO - /builds/worker/workspace/build/src/config/recurse.mk:101: recipe for target 'toolkit/library/rust/check' failed
[task 2018-11-06T14:44:31.778Z] 14:44:31     INFO - make[1]: *** [toolkit/library/rust/check] Error 2
[task 2018-11-06T14:44:31.778Z] 14:44:31     INFO - make[1]: Target 'recurse_check' not remade because of errors.
[task 2018-11-06T14:44:31.778Z] 14:44:31     INFO - make[1]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox'
[task 2018-11-06T14:44:31.778Z] 14:44:31     INFO - /builds/worker/workspace/build/src/config/recurse.mk:32: recipe for target 'check' failed
[task 2018-11-06T14:44:31.778Z] 14:44:31     INFO - make: *** [check] Error 2
[task 2018-11-06T14:44:31.779Z] 14:44:31     INFO - 327 compiler warnings present.
[task 2018-11-06T14:44:31.826Z] 14:44:31     INFO - Notification center failed: Install notify-send (usually part of the libnotify package) to get a notification when the build finishes.
[task 2018-11-06T14:44:31.846Z] 14:44:31    ERROR - Return code: 2
[task 2018-11-06T14:44:31.847Z] 14:44:31     INFO - TinderboxPrint: check<br/>14/0/0
[task 2018-11-06T14:44:31.847Z] 14:44:31  WARNING - setting return code to 2
[task 2018-11-06T14:44:31.847Z] 14:44:31    ERROR - 'mach build check' did not run successfully. Please check log for errors.
[task 2018-11-06T14:44:31.847Z] 14:44:31     INFO - [mozharness: 2018-11-06 14:44:31.847651Z] Finished check-test step (success)
[task 2018-11-06T14:44:31.847Z] 14:44:31     INFO - [mozharness: 2018-11-06 14:44:31.847810Z] Skipping valgrind-test step.
[task 2018-11-06T14:44:31.848Z] 14:44:31     INFO - [mozharness: 2018-11-06 14:44:31.847953Z] Skipping multi-l10n step.
[task 2018-11-06T14:44:31.848Z] 14:44:31     INFO - [mozharness: 2018-11-06 14:44:31.848096Z] Skipping package-source step.
[task 2018-11-06T14:44:31.848Z] 14:44:31     INFO - Running post-run listener: _shutdown_sccache
Flags: needinfo?(ehsan)
Depends on: 1505064
Flags: needinfo?(ehsan)
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1c0f3252fdf7
Make sure the STATE_LOADED_TRACKING_CONTENT state is stored outside of the content blocking log r=baku
https://hg.mozilla.org/mozilla-central/rev/1c0f3252fdf7
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Depends on: 1508527
You need to log in before you can comment on or make changes to this bug.