1504775 - Index is wrong for restored tabs

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P3)

Description

[glacambre]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:63.0) Gecko/20100101 Firefox/63.0

Steps to reproduce:

Open tab A. Open tab B. Open tab C. Close tab C. Close tab B. Run `browser.sessions.getRecentlyClosed(tabs => browser.sessions.restore(tabs[1].tab.sessionId))` and then `browser.tabs.query({}).then(console.log)`.


Actual results:

Tab C is restored with index 3.


Expected results:

Tab C should be restored with index 2.

Comment 1

[Kris Maglione [:kmag]]

I don't understand what you're reporting here. How many tabs were open to begin with? Are the tabs restored in the expected order and reporting the wrong index, or restored in the wrong order and reporting the correct index?

Comment 2

[glacambre]

>How many tabs were open to begin with?

A single tab was open before running the reproduction steps.

>Are the tabs restored in the expected order and reporting the wrong index, or restored in the wrong order and reporting the correct index?

Correct order, wrong index. Here's what happens in more detail:

Original tab: index 0
[Open tab A]
Original tab: index 0
Tab A: index 1
[Open tab B]
Original tab: index 0
Tab A: index 1
Tab B: index 2
[Open tab C]
Original tab: index 0
Tab A: index 1
Tab B: index 2
Tab C: index 3
[Close tab C]
Original tab: index 0
Tab A: index 1
Tab B: index 2
[Close tab B]
Original tab: index 0
Tab A: index 1
[Restore tab C (browser.sessions.getRecentlyClosed(tabs => browser.sessions.restore(tabs[1].tab.sessionId)))]
Original tab: index 0
Tab A: index 1
Tab C: index 3

Comment 3

[Kris Maglione [:kmag]]

OK. This is probably a session restore or tabbrowser bug, then. We get the tab index from a property on the browser tab.

Comment 4

[Dão Gottwald [:dao]]

I believe bug 1449700 broke this.

Comment 5

[Dão Gottwald [:dao]]

Attachment: Bug 1504775 - Ensure externally provided addTab index is within bounds. r=mixedpuppy

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cbf847b4007c
Ensure externally provided addTab index is within bounds. r=mixedpuppy

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/cbf847b4007c

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/cbf847b4007c

Comment 9

[YUKI "Piro" Hiroshi]

This bug looks to break the compatibility of WebExtensions API with Chromium: the bug 1541748.