1504857 - URLs not ending in a slash result in an ISE

Status: RESOLVED FIXED

(Conduit :: Lando, enhancement, P1)

Description

[Mark Côté [:mcote]]

Something to do with recent changes to lando-ui, probably dependencies, has resulted in 500 errors when loading a URL without a trailing slash, e.g.     https://lando.devsvcdev.mozaws.net/revisions/D156/1014.  It used to redirect with a 301 (see current production). 

This is a big problem because the "View in Lando" link doesn't end in a slash.  While we are going to remove that link in favour of the "View stack in Lando" link, we should still fix this, partly because it will cause problems until the next Phab deploy, and partly because, well, this should work.

Comment 1

[Israel Madueme [:imadueme]]

Attachment: errorhandlers: pass through 301 redirect exceptions

werkzeug uses exceptions to signal a 301 redirect. before this commit
we were catching that as an unexpected exception and showing what looks
like a 500. now we allow the flask app to handle that exception and redirect
appropriately.

WIP: TODO: add unit test

Comment 2

[Israel Madueme [:imadueme]]

Exposed by upgrading werkzeug from 0.12 to 0.14 (I think)

Comment 3

[Israel Madueme [:imadueme]]

deploying soon