1504946 - Deprecate moz-prefixed fullscreen API

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Comment 1

[Andrea Marchesini [:baku]]

Attachment: fullscreenDeprecation.patch

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 9022848 [details] [diff] [review]
fullscreenDeprecation.patch

> # LOCALIZATION NOTE (CreateImageBitmapCanvasRenderingContext2DWarning): Do not translate CanvasRenderingContext2D and createImageBitmap.
> CreateImageBitmapCanvasRenderingContext2DWarning=Use of CanvasRenderingContext2D in createImageBitmap is deprecated.
>+# LOCALIZATION NOTE (MozRequestFullScreenDeprecatedPrefixWarning): Do not translate Element.mozRequestFullScreen.
>+MozRequestFullScreenDeprecatedPrefixWarning=Element.mozRequestFullScreen() is deprecated.
>+# LOCALIZATION NOTE (MozfullscreenchangeDeprecatedPrefixWarning): Do not translate GlobalEventHandlers.onmozfullscreenchange.
>+MozfullscreenchangeDeprecatedPrefixWarning=GlobalEventHandlers.onmozfullscreenchange is deprecated.
>+# LOCALIZATION NOTE (MozfullscreenerrorDeprecatedPrefixWarning): Do not translate GlobalEventHandlers.onmozfullscreenerror.
>+MozfullscreenerrorDeprecatedPrefixWarning=GlobalEventHandlers.onmozfullscreenerror is deprecated.

I would drop GlobalEventHandlers from the messages. GlobalEventHandlers isn't something exposed to the web pages as such, it is just
webidl way to have event handlers on various EventTargets.
And to be consistent, drop also Element. from the first one. Both from comment and actual message

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/601941827824
Deprecate moz-prefixed fullscreen API, r=smaug

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/601941827824

Comment 5

[Kohei Yoshino [:kohei]]

Updated the site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2018/fullscreen-api-has-been-unprefixed/

Comment 6

[Chris Mills [:cmills]]

Note to writer's team:

I've added a note to the Fx65 rel notes about this:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/65#APIs

In terms of docs, it looks like this'll need some additions to the compat data (maybe), but not a lot else. You could probably just wait until they are removed altogether.

Comment 7

[Eric Shepherd [:sheppy]]

Updated the following pages with content clarifications, style fixes, tag additions and corrections, improved linking, and generally better quality. Added sidebars to the event reference pages.

• https://developer.mozilla.org/en-US/docs/Web/Events/fullscreenchange
• https://developer.mozilla.org/en-US/docs/Web/Events/fullscreenerror
• https://developer.mozilla.org/en-US/docs/Web/API/Document/onfullscreenchange
• https://developer.mozilla.org/en-US/docs/Web/API/Document/onfullscreenerror
• https://developer.mozilla.org/en-US/docs/Web/API/Element/onfullscreenchange
• https://developer.mozilla.org/en-US/docs/Web/API/Element/onfullscreenerror

Also, submitted PR 3346 to update compatibility data.