Closed Bug 1504946 Opened 11 months ago Closed 11 months ago

Deprecate moz-prefixed fullscreen API

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: baku, Assigned: baku)

Details

(Keywords: dev-doc-complete, site-compat)

Attachments

(1 file)

No description provided.
Attachment #9022848 - Flags: review?(bugs)
Comment on attachment 9022848 [details] [diff] [review]
fullscreenDeprecation.patch

> # LOCALIZATION NOTE (CreateImageBitmapCanvasRenderingContext2DWarning): Do not translate CanvasRenderingContext2D and createImageBitmap.
> CreateImageBitmapCanvasRenderingContext2DWarning=Use of CanvasRenderingContext2D in createImageBitmap is deprecated.
>+# LOCALIZATION NOTE (MozRequestFullScreenDeprecatedPrefixWarning): Do not translate Element.mozRequestFullScreen.
>+MozRequestFullScreenDeprecatedPrefixWarning=Element.mozRequestFullScreen() is deprecated.
>+# LOCALIZATION NOTE (MozfullscreenchangeDeprecatedPrefixWarning): Do not translate GlobalEventHandlers.onmozfullscreenchange.
>+MozfullscreenchangeDeprecatedPrefixWarning=GlobalEventHandlers.onmozfullscreenchange is deprecated.
>+# LOCALIZATION NOTE (MozfullscreenerrorDeprecatedPrefixWarning): Do not translate GlobalEventHandlers.onmozfullscreenerror.
>+MozfullscreenerrorDeprecatedPrefixWarning=GlobalEventHandlers.onmozfullscreenerror is deprecated.

I would drop GlobalEventHandlers from the messages. GlobalEventHandlers isn't something exposed to the web pages as such, it is just
webidl way to have event handlers on various EventTargets.
And to be consistent, drop also Element. from the first one. Both from comment and actual message
Attachment #9022848 - Flags: review?(bugs) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/601941827824
Deprecate moz-prefixed fullscreen API, r=smaug
https://hg.mozilla.org/mozilla-central/rev/601941827824
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Note to writer's team:

I've added a note to the Fx65 rel notes about this:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/65#APIs

In terms of docs, it looks like this'll need some additions to the compat data (maybe), but not a lot else. You could probably just wait until they are removed altogether.
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.