Closed
Bug 1505285
Opened 6 years ago
Closed 6 years ago
[remote-dbg-next] No favicons for tabs
Categories
(DevTools :: about:debugging, defect, P1)
DevTools
about:debugging
Tracking
(firefox-esr60 unaffected, firefox63 unaffected, firefox64 unaffected, firefox65 fixed)
RESOLVED
FIXED
Firefox 65
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox63 | --- | unaffected |
| firefox64 | --- | unaffected |
| firefox65 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
(Blocks 2 open bugs)
Details
(Keywords: regression)
Attachments
(2 files)
STRs: - enable and open new about:debugging - connect to Firefox for Android via USB - select the Device in the sidebar ER: The tabs should show the correct favicon. AR: All tabs have the default globe icon. We improved the favicon support in https://bugzilla.mozilla.org/show_bug.cgi?id=1272774 but I thought our code to retrieve favicons was working also for remote debugging.
|
Assignee | |
Comment 1•6 years ago
|
||
ni? to verify this.
Status: NEW → UNCONFIRMED
Ever confirmed: false
Flags: needinfo?(jdescottes)
|
|
Assignee | |
Comment 2•6 years ago
|
||
Actually there are no favicons anywhere, even for local runtime.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(jdescottes)
Summary: [remote-dbg-next] No favicons for tabs of USB runtime → [remote-dbg-next] No favicons for tabs
|
|
Assignee | |
Comment 3•6 years ago
|
||
Also affecting the current about:debugging. Not happening in DevEdition, recent regression.
Keywords: regression
Priority: P3 → P2
|
|
Assignee | |
Comment 4•6 years ago
|
||
regression from Bug 1485661, favicons argument no longer working for listTabs.
Blocks: 1485661
|
|
Assignee | |
Comment 5•6 years ago
|
||
Fixing this and adding a mochitest.
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 6•6 years ago
|
||
|
|
Assignee | |
Comment 7•6 years ago
|
||
Depends on D11161
|
|
Assignee | |
Comment 8•6 years ago
|
||
try is green https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=210296698&revision=c97b2123638939b09e84155c15ab4f60647efd2c
|
|
Assignee | |
Comment 9•6 years ago
|
||
Need to check if this also fixed the issue for remote debugging.
Flags: needinfo?(jdescottes)
|
|
Assignee | |
Updated•6 years ago
|
Flags: needinfo?(jdescottes)
|
|
Assignee | |
Updated•6 years ago
|
Priority: P2 → P1
|
|
Assignee | |
Comment 10•6 years ago
|
||
I verified it was working when debugging a remote Firefox 65. I could not get it to work when debugging Firefox for Android, but it might be a backward compatibility issue? Will try with a local Firefox for Android build.
Flags: needinfo?(jdescottes)
|
|
Assignee | |
Comment 11•6 years ago
|
||
Keeping the ni? while my Android environment is building, but I see the same behavior when debugging Firefox 63 from my local build so I'm confident this should work when debugging the same version of Firefox.
|
|
Assignee | |
Comment 12•6 years ago
|
||
This is still not working on Android, will file a separate bug.
Flags: needinfo?(jdescottes)
|
||
Comment 13•6 years ago
|
||
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f7f739f5f02f Restore favicons option for root listTabs;r=ochameau https://hg.mozilla.org/integration/autoland/rev/5e33f5fe95e3 Add mochitest to check that aboutdebugging shows tab favicons;r=ladybenko
|
||
Comment 14•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f7f739f5f02f https://hg.mozilla.org/mozilla-central/rev/5e33f5fe95e3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
|
||
Updated•6 years ago
|
status-firefox63:
--- → unaffected
status-firefox64:
--- → unaffected
status-firefox-esr60:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•