1505289 - [remote-dbg-next] UX: Show previously connected devices in the sidebar

Status: VERIFIED FIXED

(DevTools :: about:debugging, defect, P1)

Description

[Julian Descottes [:jdescottes]]

After discovering a device, when the device is disconnected, it simply disappears for the sidebar. 

STRs:
- connect via USB to Firefox for Android using new about:debugging
- device appears in the about:debugging sidebar
- disconnect the USB cable
=> Device suddenly disappears from the sidebar

It might be better to keep it a status "USB disconnected" as shown in the initial mockups at https://mozilla.invisionapp.com/share/F9IVW9WPG4W#/screens/297684721 (last screen, scroll down to the bottom).

This should probably be split between UX and implementation.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1505289 - Move unknown runtime logic to aboutdebugging

The notion of unknown runtime is only relevant to aboutdebugging
As we will complexify this to handle unplugged devices, moving it to aboutdebugging seems reasonable.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1505289 - Show unplugged USB devices in about:debugging

Depends on D25779
To avoid confusion with connection/disconnection to runtimes, I use "unplugged" here. Makes sense for USB, might not make sense of we extend it to other connection types

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1505289 - Handle unplugged devices in telemetry middleware

Depends on D25780

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1505289 - Mock adb instead of usb-runtimes in aboutdebugging tests

Depends on D25782

Mocking adb instead of usb-runtimes module. Now that usb-runtimes has more logic, it makes sense to test it in our mochitests.

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1505289 - Add test for unplugged USB runtimes

Depends on D25783

Comment 6

[Julian Descottes [:jdescottes]]

try https://treeherder.mozilla.org/#/jobs?repo=try&revision=980a92e0727ec3ea2e76acf9d7edc08b6c3c1cbe

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 1505289 - Rename unknown (usb runtimes) to unavailable;r=Ola

Depends on D25784

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88f37063a1ff
Move unknown runtime logic to aboutdebugging r=Ola,ladybenko
https://hg.mozilla.org/integration/autoland/rev/d864f9d6ce00
Show unplugged USB devices in about:debugging r=Ola,ladybenko,flod
https://hg.mozilla.org/integration/autoland/rev/3b2597e84231
Handle unplugged devices in telemetry middleware r=Ola,ladybenko
https://hg.mozilla.org/integration/autoland/rev/c3aea0459e5c
Mock adb instead of usb-runtimes in aboutdebugging tests r=Ola,ladybenko
https://hg.mozilla.org/integration/autoland/rev/5b4e9571635e
Add test for unplugged USB runtimes r=ladybenko
https://hg.mozilla.org/integration/autoland/rev/630d6ce9c7b0
Rename unknown (usb runtimes) to unavailable;r=Ola

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/88f37063a1ff
https://hg.mozilla.org/mozilla-central/rev/d864f9d6ce00
https://hg.mozilla.org/mozilla-central/rev/3b2597e84231
https://hg.mozilla.org/mozilla-central/rev/c3aea0459e5c
https://hg.mozilla.org/mozilla-central/rev/5b4e9571635e
https://hg.mozilla.org/mozilla-central/rev/630d6ce9c7b0

Comment 10

[Patrick Brosset <:pbro>]

Attachment: image7.png

Adding a screenshot to show what unplugged USB devices now look like in the UI.

Comment 12

[Hani Yacoub]

Verified as fixed on Firefox Nightly 69.0a1 (2019-05-29) and on Firefox 68.0b5 on Windows 10 x 64, Mac OS X 10.14 and on Ubuntu 18.04 x64.