1505295 - Remove unused BarGraphWidget

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P2)

Description

[Alexandre Poirot [:ochameau]]

This widget seems to no longer be used by any code but its own tests:
https://searchfox.org/mozilla-central/search?q=BarGraphWidget&case=false&regexp=false&path=

Comment 1

[Manish [:manishkk]]

Need to remove these test files also?

https://searchfox.org/mozilla-central/source/devtools/client/shared/test/browser_graphs-11a.js
https://searchfox.org/mozilla-central/source/devtools/client/shared/test/browser_graphs-11b.js
https://searchfox.org/mozilla-central/source/devtools/client/shared/test/browser_graphs-12.js

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

(In reply to Manish [:manishkk] from comment #1)

Need to remove these test files also?

https://searchfox.org/mozilla-central/source/devtools/client/shared/test/browser_graphs-11a.js
https://searchfox.org/mozilla-central/source/devtools/client/shared/test/browser_graphs-11b.js
https://searchfox.org/mozilla-central/source/devtools/client/shared/test/browser_graphs-12.js

Yes, these should be removed as well. In addition, to their entries in https://searchfox.org/mozilla-central/source/devtools/client/shared/test/browser.ini.

Comment 3

[Manish [:manishkk]]

Attachment: Bug 1505295- Remove unused BarGraphWidget

Comment 4

[Alexandre Poirot [:ochameau]]

The patch looks good, should we land this patch (it would need a rebase)?

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/af94f72eeb78
Remove unused BarGraphWidget. r=gl

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/af94f72eeb78