Remove unused BarGraphWidget
Categories
(DevTools :: General, enhancement, P2)
Tracking
(firefox70 fixed)
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: ochameau, Assigned: manishkk)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
This widget seems to no longer be used by any code but its own tests: https://searchfox.org/mozilla-central/search?q=BarGraphWidget&case=false®exp=false&path=
|
||
Updated•6 years ago
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
Need to remove these test files also?
https://searchfox.org/mozilla-central/source/devtools/client/shared/test/browser_graphs-11a.js
https://searchfox.org/mozilla-central/source/devtools/client/shared/test/browser_graphs-11b.js
https://searchfox.org/mozilla-central/source/devtools/client/shared/test/browser_graphs-12.js
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 2•5 years ago
|
||
(In reply to Manish [:manishkk] from comment #1)
Need to remove these test files also?
https://searchfox.org/mozilla-central/source/devtools/client/shared/test/browser_graphs-11a.js
https://searchfox.org/mozilla-central/source/devtools/client/shared/test/browser_graphs-11b.js
https://searchfox.org/mozilla-central/source/devtools/client/shared/test/browser_graphs-12.js
Yes, these should be removed as well. In addition, to their entries in https://searchfox.org/mozilla-central/source/devtools/client/shared/test/browser.ini.
|
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
Reporter | |
Comment 4•5 years ago
|
||
The patch looks good, should we land this patch (it would need a rebase)?
Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/af94f72eeb78 Remove unused BarGraphWidget. r=gl
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Description
•