1505360 - Please add build system support for NetBSD/sparc64

Status: NEW

(Core :: XPCOM, enhancement)

Description

[Martin Husemann]

Attachment: moz.build.patch

This simple patch adds support for NetBSD/sparc64 and should not affect any other platform.

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 9023248 [details] [diff] [review]
moz.build.patch

Review of attachment 9023248 [details] [diff] [review]:
-----------------------------------------------------------------

WFM, thanks!  You probably want to fix the patch to not be modifying moz.build.orig, though. :)

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:martin, could you have a look please?

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:nika, since the bug has recent activity, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 6

[Andrew McCreight [:mccr8]]

since the bug has recent activity

Did it though...

Comment 7

[Andrew McCreight [:mccr8]]

I filed an issue about the bot treating the bot activity as "recent activity".

Comment 8

[Andrew McCreight [:mccr8]]

Comment on attachment 9023248 [details] [diff] [review]
moz.build.patch

I'm going to mark this patch obsolete so the bot doesn't needinfo Nika again. It does also look like it needs to be rewritten in any event.

Comment 9

[nia]

Attachment: xpcom.patch

Comment 10

[nia]

Note that the condition covers (effectively) every single operating system that runs on sparc64 chips.

I think it is safe to remove the OS-specific check.

Comment 11

[Gabriele Svelto [:gsvelto]]

Can you upload the (fixed) patch to Phabricator so we can review and apply it? Instructions are here: https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

If you need help just ping me.

Comment 12

[nia]

(In reply to Gabriele Svelto [:gsvelto] from comment #11)

Can you upload the (fixed) patch to Phabricator so we can review and apply it? Instructions are here: https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

If you need help just ping me.

Hi, sorry for the delay, I was in hospital. Unfortunately i'm struggling with this due to my internet connection struggling with the mozilla hg repository.

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.