Closed Bug 1505366 Opened 7 years ago Closed 6 years ago

Intermittent /xhr/responsexml-document-properties.htm | lastModified set to time of response if no HTTP header provided - assert_greater_than_equal: expected a number greater than or equal to 1541322656 but got 1541319056

Categories

(Core :: DOM: Networking, defect, P2)

Product:
Core
Component:
DOM: Networking
Type:
defect

Tracking

()

Status:
RESOLVED INCOMPLETE

People

(Reporter: intermittent-bug-filer, Unassigned)

Details

(Keywords: intermittent-failure, Whiteboard: [necko-triaged])

Filed by: archaeopteryx [at] coole-files.de https://treeherder.mozilla.org/logviewer.html#?job_id=209676558&repo=autoland https://queue.taskcluster.net/v1/task/RNAimYUTRcuT17QFYNrXVQ/runs/0/artifacts/public/logs/live_backing.log 01:10:56 INFO - TEST-START | /xhr/responsexml-document-properties.htm 01:10:56 INFO - 01:10:56 INFO - TEST-PASS | /xhr/responsexml-document-properties.htm | contentType 01:10:56 INFO - TEST-PASS | /xhr/responsexml-document-properties.htm | readyState 01:10:56 INFO - TEST-PASS | /xhr/responsexml-document-properties.htm | location 01:10:56 INFO - TEST-PASS | /xhr/responsexml-document-properties.htm | defaultView 01:10:56 INFO - TEST-PASS | /xhr/responsexml-document-properties.htm | body 01:10:56 INFO - TEST-PASS | /xhr/responsexml-document-properties.htm | doctype 01:10:56 INFO - TEST-PASS | /xhr/responsexml-document-properties.htm | all 01:10:56 INFO - TEST-FAIL | /xhr/responsexml-document-properties.htm | cookie - assert_equals: expected (string) "" but got (undefined) undefined 01:10:56 INFO - runTest/<@http://web-platform.test:8000/xhr/responsexml-document-properties.htm:39:11 01:10:56 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1561:20 01:10:56 INFO - test@http://web-platform.test:8000/resources/testharness.js:544:21 01:10:56 INFO - runTest@http://web-platform.test:8000/xhr/responsexml-document-properties.htm:38:9 01:10:56 INFO - @http://web-platform.test:8000/xhr/responsexml-document-properties.htm:34:9 01:10:56 INFO - TEST-PASS | /xhr/responsexml-document-properties.htm | Test document URL properties after redirect 01:10:56 INFO - TEST-PASS | /xhr/responsexml-document-properties.htm | Test document URL properties of document with <base> after redirect 01:10:56 INFO - TEST-UNEXPECTED-FAIL | /xhr/responsexml-document-properties.htm | lastModified set to time of response if no HTTP header provided - assert_greater_than_equal: expected a number greater than or equal to 1541322656 but got 1541319056 01:10:56 INFO - @http://web-platform.test:8000/xhr/responsexml-document-properties.htm:78:9 01:10:56 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1561:20 01:10:56 INFO - test@http://web-platform.test:8000/resources/testharness.js:544:21 01:10:56 INFO - @http://web-platform.test:8000/xhr/responsexml-document-properties.htm:75:7 01:10:56 INFO - ....... 01:10:56 INFO - TEST-OK | /xhr/responsexml-document-properties.htm | took 254ms
Daniel - can you have a look at this please?
Assignee: nobody → daniel
Priority: P5 → P2
The time difference between the two time stamps is exactly 3600 seconds == 1 hour. Daylight saving time related?
Hi Thomas, You seem to have added this particular test back in 2016. I've not fully grasped exactly how this test works, but based on the time diff mentioned above and the fact that this failure ran very close in time to the US daylight saving change, do you think this this can be the explanation?
Flags: needinfo?(twisniewski)
Please investigate any cookie involvement here, also. Thanks!
Assignee: daniel → nobody

Sorry for the delay here. The test in question is just checking that the various properties on an XMLHttpRequest's responseXML property seem sane, by doing a few controlled XHRs and checking their properties.

The reason it checks dates at all is because of the responseXML.lastModified object, which can be affected by HTTP headers. It does stand to reason that since I'm using Date.getTime(), any sudden change due to daylight savings would cause exactly the error we saw here (especially since we apparently haven't seen it again since).

The cookie-related failure is beyond me, however. I don't understand why a document's cookie would end up undefined like that after fetching a responseXML. Ehsan, is there a known reason for that to happen? All the code is essentially doing is this:

      var client = new XMLHttpRequest();
      client.open("GET", "resources/well-formed.xml", false); // sync XHR
      client.send(null);
      // check a bunch of values, such as:
      assert_equals(client.responseXML.contentType, "application/xml");
      assert_equals(client.responseXML.readyState, "complete");
      assert_equals(client.responseXML.cookie, ""); // ultimately fails here

I don't understand why the cookie would be undefined if the other values seemed correct, which the test results are claiming.

Flags: needinfo?(twisniewski) → needinfo?(ehsan)

The cookie related failures are bug 144795 (completely unrelated to the intermittent failure being discussed here).

Flags: needinfo?(ehsan)
Whiteboard: [necko-triaged]

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.