1505375 - Make WR display list dumping go to logcat on android

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

While working on bug 1503616 I found that the WR display list dumping goes to stderr, and doesn't get copied to logcat on android. It's useful to have it in logcat so this bug is to fix that. I have a hacky fix locally that will need cleaning up.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6042505fbd8b00e0b48eb509a049ca97f4f98e11

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1505375 - Extract a method to return the dumped display list as a string. r?kvark

For proper android support we need to dump this to logcat instead of
stderr, so it seems better to just have a function to return the dumped
string and we can send it wherever we want in the embedding application.
This also changes the print_display_list back to the original semantics
(prior to servo/webrender#2893) where it just dumps the whole display
list to stdout.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1505375 - Send the interleaved WR display list dump to logcat. r?nical

Using the gfx.webrender.dl.dump-* prefs is supposed to print a display
list dump with the gecko and WR display items appropriately interleaved.
However on Android the gecko items get sent to logcat via printf_stderr,
and the WR display items get sent to stderr, and so get lost. This makes
the WR items also go to logcat so that they show up properly.

Depends on D11195

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Fixed by 1505862