1505388 - Crash in mozilla::net::SpdyConnectTransaction::WriteSegments

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P1)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is
report bp-f4294b26-32e6-47d6-8411-f26a90181107.
=============================================================

Seen while looking at nightly crash data: . Crashes started using Build ID 	20181107100135. Possible regression range based on Build ID: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=957a743c4ca2907d8e357fce43fbcd9f619f1122&tochange=070757a0160c8e6156cf6d8d567a0af280dc33e8

Bug 1434137? ni on Nicholas.

Top 10 frames of crashing thread:

0 xul.dll mozilla::net::SpdyConnectTransaction::WriteSegments netwerk/protocol/http/TunnelUtils.cpp:1385
1 xul.dll mozilla::net::Http2Stream::WriteSegments netwerk/protocol/http/Http2Stream.cpp:319
2 xul.dll mozilla::net::Http2Session::WriteSegmentsAgain netwerk/protocol/http/Http2Session.cpp:3387
3 xul.dll mozilla::net::nsHttpConnection::OnInputStreamReady netwerk/protocol/http/nsHttpConnection.cpp:2422
4 xul.dll void mozilla::net::nsSocketInputStream::OnSocketReady netwerk/base/nsSocketTransport2.cpp:293
5 xul.dll mozilla::net::nsSocketTransport::OnSocketReady netwerk/base/nsSocketTransport2.cpp:2317
6 xul.dll mozilla::net::nsSocketTransportService::Run netwerk/base/nsSocketTransportService2.cpp:1040
7 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1246
8 xul.dll NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:530
9 xul.dll mozilla::ipc::MessagePumpForNonMainThreads::Run ipc/glue/MessagePump.cpp:364

=============================================================

Comment 1

[Marcia Knous [:marcia]]

There are Mac crashes as well (so far all on 10.14), changing platform to all.

Comment 2

[u408661]

Looks like I messed something up when separating out stuff that applies to both websockets and regular tunnels. Likely cb is null, I just need to figure out the right behaviour when that's the case (based on the previous code) and make sure that's handled properly. Aiming to have a patch later today.

Comment 3

[u408661]

Attachment: Bug 1505388 - fix crash introduced by bug Bug 1434137. r?kershaw

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f796b2c950e0
fix crash introduced by bug Bug 1434137. r=kershaw

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/f796b2c950e0