1505450 - The "CFR" recommendation is wrongly displayed on "Facebook" and "YouTube" websites if a similar add-on is installed and the website is focused when the is browser restarted

Status: NEW

(Firefox :: New Tab Page, defect, P3)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Affected versions]:
- Firefox 63.0.1 Build ID - 20181030165643
- Firefox 64.0b7 Build ID - 20181105164654
- Firefox 65.0a1 Build ID - 20181107100135

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Prerequisites]:
- Have a new Firefox profile.
- Have the following prefs in the "about:config" page;
	- "browser.newtabpage.activity-stream.asrouter.messageProviders" pref set to "[{"id":"cfr", "cohort": "one_per_day", "frequency": {"custom": [{"period": "daily", "cap": 1}]}, "type":"local","localProvider":"CFRMessageProvider","enabled":true}]";

[Steps to reproduce]:
1. Open the browser with the profile from prerequisites.
2. Open a new tab and click the "Facebook" top site.
3. Repeat step two another four times.
4. Close all the "Facebook" tabs and restart the browser.
5. Install the "Facebook™ Tracking & Ad Removal" add-on from https://goo.gl/yMRfya.
6. Open a new tab and click the "Facebook" top site.
7. Restart the browser and observe the behavior.
 
[Expected result]:
- The browser is successfully restarted.

[Actual result]:
- The "CFR" recommendation is also displayed in the right part of the "Address Bar".

[Notes]:
- This issue is also reproducible with the "YouTube" website.
- This issue is not reproducible with the "Google Translate" and "Wikipedia" websites.
- Attached a screen recording of the issue.

Comment 1

[Tim Spurway [:tspurway]]

:ursula could you check the targeting expression, addon ids, etc and see if this is actually a bug?

Comment 2

[Ursula Sarracini (:ursula)]

I checked the targeting expression, it is working as intended - filtering out the recommendation when there's an addon that intersects with the list of blocked addons. I also checked the see if the addon id is still valid, and it is. I don't think it would be the targeting, since it doesn't seem to reproduce with Google or Wikipedia according to the notes, and they all have the same targeting so that wouldn't make sense.

I can't seem to reproduce the issue myself. I'll attach a video of my attempt to reproduce and it seems to working exactly as intended for me at least. 

My guess is that it has something to do with the way it's restoring the session after restart maybe? Maybe it's caching some state and so the recommendation persists.

Comment 3

[Ursula Sarracini (:ursula)]

Here's a link to the video if you want to see how I was trying to reproduce: https://drive.google.com/file/d/1t-Kk4CB-Veu9ARzER2PBaw9yN2kVJKjH/view?usp=sharing

Comment 4

[Marius Coman [:mcoman], Ecosystem QA]

Hi Ursula, it seems that I forgot a crucial element in order to reproduce this issue, more exactly the "CFR" recommendation should not be displayed before step 7 from the description. 
Alternatively, you can also reproduce this issue, even if you already triggered the "CFR" recommendation, by moving your system's time to 24 hours in the future and then restarting the browser.

If still does not work please feel free to ping me on Slack.

Comment 5

[Ursula Sarracini (:ursula)]

Aaron, can let us know if this is ok? It's very specific conditions to reproduce, and it doesn't happen if you just visit the URL after you've restarted - it only happens if you restore the browser with the URL already open.