Closed
Bug 1505569
Opened 6 years ago
Closed 6 years ago
Use AutoCleanLinkedList in flexbox code (rather than custom AutoFlexLineListClearer class)
Categories
(Core :: Layout: Flexbox, enhancement, P3)
Core
Layout: Flexbox
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: dholbert, Assigned: dholbert)
Details
Attachments
(1 file)
nsFlexContainerFrame.cpp has a custom RAII class to delete the entries from a LinkedList when it's done with the LinkedList.
Nowadays, we have a smarter version of LinkedList that does that for us, called AutoCleanLinkedList. We should just use that instead.
|
Assignee | |
Updated•6 years ago
|
Severity: normal → trivial
Flags: in-testsuite-
|
|
Assignee | |
Comment 1•6 years ago
|
||
This patch doesn't change behavior; it's just making some custom cleanup
code unnecessary by using a better fitting container class.
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/28f9cf6d3f5a
Use AutoCleanLinkedList in flexbox code, rather than LinkedList + custom RAII class. r=mats
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•