Closed
Bug 1505651
Opened 6 years ago
Closed 5 years ago
tc-client-web WebSocket tests fail
Categories
(Taskcluster :: Services, enhancement)
Taskcluster
Services
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dustin, Unassigned)
Details
I can't figure out why. The WebSocket object emits an `error` event after construction, and the Event is basically content-less: https://stackoverflow.com/questions/18803971/websocket-onerror-how-to-read-error-description So, something is going wrong opening a websocket from the headless browser to wss://events.taskcluster.net/v1/listen/websocket -- and the browser won't tell us what.
Reporter | ||
Comment 1•6 years ago
|
||
Hassan, can you replicate this? Any idea how to get more information?
Flags: needinfo?(helfi92)
Comment 2•6 years ago
|
||
I can replicate this when I run the tests locally. Inside `handleClose`, I noticed that if I put a log statement `console.log(e.code)` I get `1006`. A quick search showed https://stackoverflow.com/a/19305172/6150432.
Flags: needinfo?(helfi92)
Comment 3•6 years ago
|
||
We could probably try migrating tc-client-web to neutrino v9 and see if it magically gets resolved.
Reporter | ||
Comment 4•6 years ago
|
||
Good find on the error code! https://tools.ietf.org/html/rfc6455#section-7.4.1 1006 1006 is a reserved value and MUST NOT be set as a status code in a Close control frame by an endpoint. It is designated for use in applications expecting a status code to indicate that the connection was closed abnormally, e.g., without sending or receiving a Close control frame. a neutrino upgrade is a good place to start..
Comment 5•6 years ago
|
||
Opened https://github.com/taskcluster/taskcluster-client-web/issues/37.
Assignee | ||
Updated•6 years ago
|
Component: Platform Libraries → Services
Reporter | ||
Comment 7•5 years ago
|
||
It seems fine in CI..
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(dustin)
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•