1505667 - SpecialPowers is not defined, in dom/base/test/unit/test_xmlserializer.js

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Tooru Fujisawa [:arai]]

https://searchfox.org/mozilla-central/source/dom/base/test/unit/test_xmlserializer.js#11
SpecialPowers is not defined in xpcshell test.
this is overlooked because of bug 1498775
patch is coming.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Fix undefined reference in dom/base/test/unit/test_xmlserializer.js, with introducing async.

Removed SpecialPowers, and rewrote the test with async, to make sure whole parts are executed.

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 9023516 [details] [diff] [review]
Fix undefined reference in dom/base/test/unit/test_xmlserializer.js, with introducing async.

Review of attachment 9023516 [details] [diff] [review]:
-----------------------------------------------------------------

r=me because this is an improvement, but this file is still ugly.

::: dom/base/test/unit/test_xmlserializer.js
@@ +7,4 @@
>      if(aFlags == undefined) aFlags = 0;
>      if(aCharset == undefined) aCharset = "UTF-8";
>  
> +    const doc = await do_parse_document(aFile, "text/xml");

nit: 'const' is surprising here. In new code we would use 'let'. If you want to match the existing style of the file, 'var' is fine.

@@ +57,3 @@
>  
>      // tests on namespaces
> +    const doc = await do_parse_document("4_original.xml", "text/xml");

same here.

Comment 3

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e7368768dd4518953a9959f6ba525e9a425f49aa
Bug 1505667 - Fix undefined reference in dom/base/test/unit/test_xmlserializer.js, with introducing async. r=florian

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/e7368768dd45