Closed
Bug 1505690
Opened 6 years ago
Closed 6 years ago
Use a HashMap instead of JSScript::vtuneMethodId_
Categories
(Core :: JavaScript Engine, enhancement, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Apparently MOZ_VTUNE is enabled by default when --enable-profiling is used. Either we change that or we have to move vtuneMethodId_ out of JSScript.
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → jdemooij
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•6 years ago
|
||
MOZ_VTUNE is defined on Nightly (because of --enable-profiling). With the
HashMap we only have some memory/perf overhead when we're actually using VTune's
JIT code profiler.
|
||
Updated•6 years ago
|
Priority: -- → P3
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/dac051017e70
Replace JSScript::vtuneMethodId_ with a HashMap. r=sstangl
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
|
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•