Closed Bug 1505690 Opened 10 months ago Closed 9 months ago

Use a HashMap instead of JSScript::vtuneMethodId_

Categories

(Core :: JavaScript Engine, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Apparently MOZ_VTUNE is enabled by default when --enable-profiling is used. Either we change that or we have to move vtuneMethodId_ out of JSScript.
URL: http://
Assignee: nobody → jdemooij
Status: NEW → ASSIGNED
MOZ_VTUNE is defined on Nightly (because of --enable-profiling). With the
HashMap we only have some memory/perf overhead when we're actually using VTune's
JIT code profiler.
Priority: -- → P3
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/dac051017e70
Replace JSScript::vtuneMethodId_ with a HashMap. r=sstangl
https://hg.mozilla.org/mozilla-central/rev/dac051017e70
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.