1505769 - When UAC permission is denied for msiexec /quiet - the logs report Firefox successfully installed

Status: NEW

(Firefox :: Installer, defect, P3)

Description

[Adrian Florinescu [:aflorinescu]]

[Description]:
https://docs.google.com/document/d/1h4oQL2xmQu2SR-8JAZiimJoWAnbJYe29Zwk8H3YN9RA/edit#

/q, /quiet, and /passive
Sets the UI mode. The full UI option (/qf) is accepted but ignored, because we have no full UI.

[Affected platforms]:
-Windows 7(32x/64x) - No UAC permission is required
-Windows 8.1(32x/64x)
-Windows 10(32x/64x)

[Steps to reproduce]:
1. Download an Firefox wrapped MSI.
2. With UAC on High Use the msiexec /quiet parameter to install Firefox.
3. Press "No" when the UAC permission dialog pop-us.


[Expected result]: (firefox is not installed)
The installer aborts with failure message in the install.log

[Actual result]: (firefox is not installed)
Windows 8.1 : after the first "No" selected, the dialog is shown again.
Windows 10: after the first "No" selected, the installation is aborted.
Windows 7: No UAC permission is required

The install log lists:

MSI (s) (04:6C) [13:37:48:676]: Product: Mozilla Firefox 65.0a1 x64 en-CA -- Installation completed successfully.

MSI (s) (04:6C) [13:37:48:676]: Windows Installer installed the product. Product Name: Mozilla Firefox 65.0a1 x64 en-CA. Product Version: 0.0.0.0. Product Language: 0. Manufacturer: Mozilla. Installation success or error status: 0.


For the above steps (selecting "No" for UAC permission pop-up in the case of /i install) the install log shows:

MSI (c) (CC:10) [13:36:56:427]: Product: Mozilla Firefox 65.0a1 x64 en-CA -- Installation failed.

MSI (c) (CC:10) [13:36:56:427]: Windows Installer installed the product. Product Name: Mozilla Firefox 65.0a1 x64 en-CA. Product Version: 0.0.0.0. Product Language: 0. Manufacturer: Mozilla. Installation success or error status: 1602.

Comment 1

[Adrian Florinescu [:aflorinescu]]

[Note:] For Windows 7, no UAC permission pop-up is displayed for the /quiet option. For normal /i install it shows the UAC permission pop-up.

Comment 2

[Molly Howell (she/her) (mostly inactive)]

This is closely related to bug 1505462; it's a similar situation to what I talked about over there where in silent mode the installer assumes the user knows what they're doing and won't report a failure even if things go really very wrong (as they will if you cancel the UAC prompt and haven't set a custom install path). We should probably start reporting that failure via an exit code from the full installer, although I don't really know if there would be any indication visible to the user of the MSI even then.