1505859 - Improve ergonomics for running rusttests locally

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Chris Manchester (limited bugmail, email directly)]

Things are better as a result of bug 1505072, but the ergonomics aren't ideal still because one still needs to set a flag to run these locally. We would be able to get rid of this flag, except the code coverage builds want to run these tests during make check rather than a separate task. I think we should just move these to a separate task like the rest of the builds for consistency.

Comment 1

[(not currently active) Ted Mielczarek]

I propose that we remove the check for `MOZ_RUST_TESTS` in the emitter, so that we always output info about Rust tests to the backend:
https://dxr.mozilla.org/mozilla-central/rev/c291143e24019097d087f9307e59b49facaf90cb/python/mozbuild/mozbuild/frontend/emitter.py#1319

and also remove the `check::` rule currently in rules.mk so that the tests won't get run during a normal `make check`:
https://dxr.mozilla.org/mozilla-central/rev/c291143e24019097d087f9307e59b49facaf90cb/config/rules.mk#1063

Then in the root Makefile just add something like:
```
ifdef MOZ_RUST_TESTS
check:: recurse_rusttests
endif
```

So that builds with --enable-rust-tests that run `make check` will still run the tests.

Comment 2

[(not currently active) Ted Mielczarek]

I forgot to add: with those changes anyone should be able to run `mach build recurse_rusttests` to build and run these tests. We should still stick that behind a mach command for better ergonomics.

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Oh yeah, that sounds even better.

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1505859 - Allow rusttests to run when requested without --enable-rust-tests.

Comment 5

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1505859 - Implement a mach wrapper for rusttests.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de5d9f1a6e4a
Allow rusttests to run when requested without --enable-rust-tests. r=firefox-build-system-reviewers,ted
https://hg.mozilla.org/integration/autoland/rev/8e4063938d4b
Implement a mach wrapper for rusttests. r=firefox-build-system-reviewers,ted

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/de5d9f1a6e4a
https://hg.mozilla.org/mozilla-central/rev/8e4063938d4b