Closed
Bug 1505890
Opened 6 years ago
Closed 6 years ago
Pinned sites targeting throws if pinned links contains null
Categories
(Firefox :: Messaging System, enhancement, P1)
Firefox
Messaging System
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: k88hudson, Assigned: k88hudson)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
This is currently causing our devtools to crash and sometimes makes this targeting property not work; we should handle the case where pinned sites can contain null.
|
||
Comment 1•6 years ago
|
||
|
||
Comment 2•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/e9c9f7e1f43909e907615c1c33ac6542b39b4de1 Bug 1505890 - Pinned sites targeting should handle null entries
|
||
Comment 3•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9fce755a1262
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
|
|
||
Comment 4•6 years ago
|
||
Bug 1505929 comment 4 backout link: https://hg.mozilla.org/mozilla-central/rev/4efd19ac076280abf1365b0bb7fd2018ce162b38
status-firefox65:
fixed → ---
Target Milestone: Firefox 65 → ---
|
|
||
Comment 5•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a46fe158e566
status-firefox65:
--- → fixed
Target Milestone: --- → Firefox 65
|
|
||
Updated•5 years ago
|
Component: Activity Streams: Newtab → Messaging System
You need to log in
before you can comment on or make changes to this bug.
Description
•