1505894 - Let addon items update their state in the UI themselves

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Add-on Manager, enhancement, P5)

Description

[Jan Henning [:JanH]]

This is most important for themes, where enabling a theme will disable the previously active theme, and disabling the current theme will enable the default theme, which means the theme state in the UI will have to be updated without refreshing the whole page.

about:addons currently does this manually [1], but apparently a better way would be to have the "Addons" object in aboutAddons.js just implement "onEnabled" and "onDisabled" to update the UI state from there.


[1] https://dxr.mozilla.org/mozilla-central/rev/c291143e24019097d087f9307e59b49facaf90cb/mobile/android/chrome/content/aboutAddons.js#525-539 - actually in that revision, about:addons is not just manually updating the UI state, but also disabling the previously active theme as well. The latter bit is already unnecessary and will be removed in bug 1429488.

Comment 1

[Jan Henning [:JanH]]

... and the current code doesn't handle uninstalling the current theme at all, i.e. the default theme isn't shown as enabled afterwards unless you refresh the page.

Comment 2

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.