1505921 - update rust version check for oom hooking

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Nathan Froyd [:froydnj]]

Rust 1.30 is out, which means nightly is 1.32.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: aar# Attachment to Bug 1505921 - update rust version check for oom hooking

update rust version check for oom hooking

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 9023761 [details] [diff] [review]
aar# Attachment to Bug 1505921 - update rust version check for oom hooking

Review of attachment 9023761 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine to me, but I've been trusting glandium to catch any subtleties about this situation.

Comment 3

[Nathan Froyd [:froydnj]]

Attachment: update rust version check for oom hooking

Rust 1.30 is out, which means nightly is 1.32.

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 9023830 [details] [diff] [review]
update rust version check for oom hooking

Review of attachment 9023830 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/library/rust/shared/build.rs
@@ +16,1 @@
>          // For the sake of the base-toolchains build we allow building with 1.27, but

Since we're way past the point where base-toolchains are using 1.27, you can actually remove this comment as well as the version check for this branch.

Comment 5

[Nathan Froyd [:froydnj]]

Attachment: update rust version check for oom hooking

Comment and version check removed; extra debugging left in.

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 9023965 [details] [diff] [review]
update rust version check for oom hooking

Review of attachment 9023965 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/library/rust/shared/build.rs
@@ +13,4 @@
>          println!("cargo:rustc-cfg=feature=\"oom_with_hook\"");
>          bootstrap = true;
> +    } else if std::env::var("MOZ_AUTOMATION").is_ok() {
> +        panic!("Builds on automation must use a version of rust that supports OOM hooking, have {:?}", ver);

While here, let's make the message clearer. Something like "Builds on automation must use a version of rust for which we know how to hook OOM (< 1.33) ; have {:?}"

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/84395a8e555f
update rust version check for oom hooking; r=chmanchester,glandium

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/84395a8e555f