Closed
Bug 1505936
Opened 7 years ago
Closed 7 years ago
pdbs for cppunittests are not copied into output zips
Categories
(Firefox Build System :: General: Unsupported Platforms, enhancement, P5)
Firefox Build System
General: Unsupported Platforms
Tracking
(firefox68 fixed)
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: tjr, Assigned: tjr)
References
Details
Attachments
(1 file, 2 obsolete files)
|
47 bytes,
text/x-phabricator-request
|
Details |
We generate them, but we don't let you download them.
Sent in a first attempt here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad72cd5e3560125a6190857bfc1aecbed10be06e
|
Assignee | |
Comment 1•7 years ago
|
||
Seems to work! Need to check the asan builds.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0e8792660de379d9d94e53a7c5174a7227ed4335
Attachment #9023794 -
Flags: review?(ted)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 9023794 [details] [diff] [review]
Bug 1505936 - Copy and provide pdbs for cppunit tests if MOZ_COPY_PDBS is specified r?ted
Review of attachment 9023794 [details] [diff] [review]:
-----------------------------------------------------------------
::: config/rules.mk
@@ +830,5 @@
> +MAIN_PDB_DEST ?= $(FINAL_TARGET)
> +MAIN_PDB_TARGET = syms
> +INSTALL_TARGETS += MAIN_PDB
> +
> +CPP_UNIT_TESTS_PDB_FILES = $(addsuffix .pdb,$(basename $(CPP_UNIT_TESTS)))
This might benefit from being inside an `ifdef CPP_UNIT_TESTS`.
Attachment #9023794 -
Flags: review?(ted) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
Carry r+ from Comment 2
Attachment #9023794 -
Attachment is obsolete: true
Attachment #9026099 -
Flags: review+
|
||
Comment 4•7 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:tjr, could you have a look please?
Flags: needinfo?(tom)
|
||
Updated•7 years ago
|
Priority: -- → P5
|
|
Assignee | |
Comment 6•7 years ago
|
||
|
|
Assignee | |
Updated•7 years ago
|
Attachment #9026099 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4e8c439818a3
Copy and provide pdbs for cppunit tests if MOZ_COPY_PDBS is specified r=firefox-build-system-reviewers,mshal
Keywords: checkin-needed
|
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in
before you can comment on or make changes to this bug.
Description
•