pdbs for cppunittests are not copied into output zips

RESOLVED FIXED in Firefox 68

Status

enhancement
P5
normal
RESOLVED FIXED
10 months ago
3 months ago

People

(Reporter: tjr, Assigned: tjr)

Tracking

Trunk
mozilla68
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

We generate them, but we don't let you download them.

Sent in a first attempt here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad72cd5e3560125a6190857bfc1aecbed10be06e
Depends on: 1506016
Comment on attachment 9023794 [details] [diff] [review]
Bug 1505936 - Copy and provide pdbs for cppunit tests if MOZ_COPY_PDBS is specified r?ted

Review of attachment 9023794 [details] [diff] [review]:
-----------------------------------------------------------------

::: config/rules.mk
@@ +830,5 @@
> +MAIN_PDB_DEST ?= $(FINAL_TARGET)
> +MAIN_PDB_TARGET = syms
> +INSTALL_TARGETS += MAIN_PDB
> +
> +CPP_UNIT_TESTS_PDB_FILES = $(addsuffix .pdb,$(basename $(CPP_UNIT_TESTS)))

This might benefit from being inside an `ifdef CPP_UNIT_TESTS`.
Attachment #9023794 - Flags: review?(ted) → review+
Carry r+ from Comment 2
Attachment #9023794 - Attachment is obsolete: true
Attachment #9026099 - Flags: review+

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:tjr, could you have a look please?

Flags: needinfo?(tom)

This bug has unresolved dependencies.

Flags: needinfo?(tom)
Priority: -- → P5
Attachment #9026099 - Attachment is obsolete: true
Keywords: checkin-needed

Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4e8c439818a3
Copy and provide pdbs for cppunit tests if MOZ_COPY_PDBS is specified r=firefox-build-system-reviewers,mshal

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.