Add cache hit/miss data to network markers

RESOLVED FIXED in Firefox 65

Status

()

enhancement
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: jesup, Assigned: jesup)

Tracking

58 Branch
mozilla65
Points:
---

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Knowing if something is a cache hit/miss/etc is helpful in debugging.  (acreskey used an earlier version of this patch to debug a raptor issue with variability).

Note that currently the cache info is only available in the Master process, but we insert Cache::Unknown for content process markers.
Attachment #9023785 - Flags: review?(mstange)
Attachment #9023785 - Flags: review?(hurley)
didn't qfold the second part (profiler/*) before submitting it, sorry)
Attachment #9023787 - Flags: review?(mstange)
Attachment #9023787 - Flags: review?(hurley)
Attachment #9023785 - Attachment is obsolete: true
Attachment #9023785 - Flags: review?(mstange)
Attachment #9023785 - Flags: review?(hurley)

Comment 3

6 months ago
Comment on attachment 9023787 [details] [diff] [review]
Add cache info to network profiler markers

Review of attachment 9023787 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks!
Attachment #9023787 - Flags: review?(hurley) → review+
Attachment #9023787 - Flags: review?(mstange) → review+

Comment 4

5 months ago
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e157b95e9b5e
Add cache info to network profiler markers r=mstange,nwgh

Comment 6

5 months ago
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b8a2b1ba813e
Add cache info to network profiler markers r=mstange,nwgh

Comment 8

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b8a2b1ba813e
Status: NEW → RESOLVED
Last Resolved: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.