Closed
Bug 1505948
Opened 6 years ago
Closed 5 years ago
Add cache hit/miss data to network markers
Categories
(Core :: Gecko Profiler, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: jesup, Assigned: jesup)
Details
Attachments
(1 file, 1 obsolete file)
18.33 KB,
patch
|
mstange
:
review+
u408661
:
review+
|
Details | Diff | Splinter Review |
Knowing if something is a cache hit/miss/etc is helpful in debugging. (acreskey used an earlier version of this patch to debug a raptor issue with variability). Note that currently the cache info is only available in the Master process, but we insert Cache::Unknown for content process markers.
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #9023785 -
Flags: review?(mstange)
Attachment #9023785 -
Flags: review?(hurley)
Assignee | ||
Comment 2•6 years ago
|
||
didn't qfold the second part (profiler/*) before submitting it, sorry)
Attachment #9023787 -
Flags: review?(mstange)
Attachment #9023787 -
Flags: review?(hurley)
Assignee | ||
Updated•6 years ago
|
Attachment #9023785 -
Attachment is obsolete: true
Attachment #9023785 -
Flags: review?(mstange)
Attachment #9023785 -
Flags: review?(hurley)
Comment on attachment 9023787 [details] [diff] [review] Add cache info to network profiler markers Review of attachment 9023787 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, thanks!
Attachment #9023787 -
Flags: review?(hurley) → review+
Updated•5 years ago
|
Attachment #9023787 -
Flags: review?(mstange) → review+
Pushed by rjesup@wgate.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e157b95e9b5e Add cache info to network profiler markers r=mstange,nwgh
Comment 5•5 years ago
|
||
Backed out changeset e157b95e9b5e (bug 1505948) for HttpChannelChild.cpp build bustages push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=211784719&revision=e157b95e9b5e1872ddc30d5d0351ae6828e05bc0 failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=c0bef417dc8e17d6a2661075ae8db9df50480b2c&selectedJob=211778974&searchStr=android%2C5.0%2Cx86-64%2Copt%2Cbuild-android-x86_64%2Fopt%2C%28b%29 backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/53001d176b97fef3a917abca40148c8b796f18fc
Flags: needinfo?(rjesup)
Pushed by rjesup@wgate.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b8a2b1ba813e Add cache info to network profiler markers r=mstange,nwgh
Assignee | ||
Comment 7•5 years ago
|
||
Relanded with bustage fix. Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=53a8f9de85ecf86e76b5e3c6a4c0a30baa142e16
Flags: needinfo?(rjesup)
Comment 8•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b8a2b1ba813e
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•