Closed Bug 1505948 Opened 6 years ago Closed 5 years ago

Add cache hit/miss data to network markers

Categories

(Core :: Gecko Profiler, enhancement)

58 Branch
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: jesup, Assigned: jesup)

Details

Attachments

(1 file, 1 obsolete file)

Knowing if something is a cache hit/miss/etc is helpful in debugging.  (acreskey used an earlier version of this patch to debug a raptor issue with variability).

Note that currently the cache info is only available in the Master process, but we insert Cache::Unknown for content process markers.
Attachment #9023785 - Flags: review?(mstange)
Attachment #9023785 - Flags: review?(hurley)
didn't qfold the second part (profiler/*) before submitting it, sorry)
Attachment #9023787 - Flags: review?(mstange)
Attachment #9023787 - Flags: review?(hurley)
Attachment #9023785 - Attachment is obsolete: true
Attachment #9023785 - Flags: review?(mstange)
Attachment #9023785 - Flags: review?(hurley)
Comment on attachment 9023787 [details] [diff] [review]
Add cache info to network profiler markers

Review of attachment 9023787 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks!
Attachment #9023787 - Flags: review?(hurley) → review+
Attachment #9023787 - Flags: review?(mstange) → review+
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e157b95e9b5e
Add cache info to network profiler markers r=mstange,nwgh
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b8a2b1ba813e
Add cache info to network profiler markers r=mstange,nwgh
https://hg.mozilla.org/mozilla-central/rev/b8a2b1ba813e
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: