1505954 - Some rust panics don't aren't properly skip listed

Status: RESOLVED FIXED

(Socorro :: Processor, task)

Description

[Jeff Muizelaar [:jrmuizel]]

See https://crash-stats.mozilla.com/report/index/f6ee9128-a2a5-4e5d-a634-5e61c0181108.

We need to do something similar to bug 1373272

Comment 1

[Jeff Muizelaar [:jrmuizel]]

https://github.com/mozilla-services/socorro/pull/4702

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 4703: fix bug 1505954: Add core::panicking::panic_bounds_check to the setinel list

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/4fea1a63f8a8c39d4c81717a9c156ab06ceff600
fix bug 1505954: add core::panicking::panic_fmt to sentinels

https://github.com/mozilla-services/socorro/commit/b393025f817160d48e56f22ee617348709de00c4
Merge pull request #4703 from jrmuizel/patch-2

fix bug 1505954: Add core::panicking::panic_bounds_check to the setinel list

Comment 4

[Kartikaya Gupta (email:[e-mail])]

https://crash-stats.mozilla.com/report/index/8d5e8882-0fb0-436c-af38-973f80181118

Since panic_bounds_check is in the sentinel list now, should the signature for this crash have the add_prim_to_batch frame in the signature?

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Bugs get marked FIXED when the code changes get merged and land in the master branch. I don't do deploys every day, so fixes accumulate until I do a prod deploy. I deployed this just now.

I reprocessed https://crash-stats.mozilla.com/report/index/8d5e8882-0fb0-436c-af38-973f80181118 and it shows this signature now:

webrender::batch::AlphaBatchBuilder::add_prim_to_batch

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Ah, thanks!

Comment 7

[Marcia Knous [:marcia]]

(In reply to Will Kahn-Greene [:willkg] ET needinfo? me from comment #5)
> Bugs get marked FIXED when the code changes get merged and land in the
> master branch. I don't do deploys every day, so fixes accumulate until I do
> a prod deploy. I deployed this just now.
> 
> I reprocessed
> https://crash-stats.mozilla.com/report/index/8d5e8882-0fb0-436c-af38-
> 973f80181118 and it shows this signature now:
> 
> webrender::batch::AlphaBatchBuilder::add_prim_to_batch

Will: Since some of the crashes which are lumped under particular signatures are not all the same crash reason, can we reprocess the crashes with the garbage signatures?

Comment 8

[Kartikaya Gupta (email:[e-mail])]

https://crash-stats.mozilla.com/search/?proto_signature=~CrashOOL%40%40&product=Firefox&version=65.0a1&date=%3E%3D2018-11-13T13%3A22%3A11.000Z&date=%3C2018-11-20T13%3A22%3A11.000Z&_sort=-date&_facets=signature&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-signature is a rough search that shows most if not all of the garbage signatures

Comment 9

[Will Kahn-Greene [:willkg] ET needinfo? me]

I reprocessed that. Signatures look better.

If there are other groups to reprocess, let me know.