1506079 - toolkit/xre/nsAppRunner.cpp:1703:8: error: unused variable 'useX11Remote' with --disable-dbus

Status: RESOLVED FIXED

(Core Graveyard :: X-remote, defect)

Description

[Jan Beich]

$ c++ -v
FreeBSD clang version 7.0.0 (tags/RELEASE_700/final 342383) (based on LLVM 7.0.0)
Target: x86_64-unknown-freebsd13.0
Thread model: posix
InstalledDir: /usr/bin

$ ./mach bootstrap
$ echo "ac_add_options --disable-dbus" >>.mozconfig
$ echo "ac_add_options --enable-warnings-as-errors # mimic MOZ_AUTOMATION" >>.mozconfig
$ ./mach build
toolkit/xre/nsAppRunner.cpp:1703:8: error: unused variable 'useX11Remote'
      [-Werror,-Wunused-variable]
  bool useX11Remote = GDK_IS_X11_DISPLAY(gdk_display_get_default());
       ^
1 error generated.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

hm, disable --disable-dbus do you say? I think we should make it mandatory for Wayland builds. Why do you build it with such configuration anyway?

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1506079 - Build and run without DBus remote client on Wayland display, r=jhorak

Comment 3

[Jan Beich]

(In reply to Martin Stránský [:stransky] from comment #1)
> hm, disable --disable-dbus do you say? I think we should make it mandatory
> for Wayland builds. Why do you build it with such configuration anyway?

I'm not building with Wayland enabled. Bug 1504937 removed `&& defined(MOZ_WAYLAND)`.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/837bb87833a3
Build and run without DBus remote client on Wayland display, r=jhorak

Comment 5

[Jan Beich]

Did the commit message and the comment in toolkit/xre/nsAppRunner.cpp arrive from the future where X11 is dead? nsAppRunner.cpp is built on all platforms, MOZ_WIDGET_GTK isn't limited to Wayland (non-default) and GDK_IS_X11_DISPLAY() is supported by Gtk3 built without Wayland support.

Comment 6

[Mike Hommey [:glandium]]

Plus, is unnecessarily dismissive.

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/837bb87833a3