layout/style/nsCSSKeywordList.h: do not format

RESOLVED FIXED in Firefox -esr60

Status

defect
RESOLVED FIXED
7 months ago
6 months ago

People

(Reporter: sylvestre, Assigned: sylvestre)

Tracking

(Blocks 1 bug)

unspecified
mozilla65
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 fixed, firefox65 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

7 months ago
causes issues like:
TEST-UNEXPECTED-FAIL | /css/css-flexbox/getcomputedstyle/flexbox_computedstyle_align-items-flex-start.html | flexbox | computed style | align-items: flex-start - assert_equals: expected "flex-start" but got "flex - start"
Assignee

Updated

7 months ago
Version: 60 Branch → unspecified

Comment 2

7 months ago
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9349b769c389
layout/style/nsCSSKeywordList.h: do not format r=andi
Assignee

Updated

7 months ago
Depends on: 1506177

Comment 3

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9349b769c389
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Assignee: nobody → sledru

Comment 4

6 months ago
Comment on attachment 9023954 [details]
Bug 1506117 - layout/style/nsCSSKeywordList.h: do not format r?andi

[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format.

User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future.

Fix Landed on Version: 65

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): NPOTB

String or UUID changes made by this patch: None
Attachment #9023954 - Flags: approval-mozilla-esr60?
Comment on attachment 9023954 [details]
Bug 1506117 - layout/style/nsCSSKeywordList.h: do not format r?andi

OK for uplift to ESR60 as part of the clang-format project.
Attachment #9023954 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
You need to log in before you can comment on or make changes to this bug.