Closed Bug 1506225 Opened 10 months ago Closed 10 months ago
Support blocking by campaign id
52 bytes, text/x-github-pull-request
|Details | Review|
This is required in order to support versioning of messages
Attachment #9024065 - Attachment description: GitHub Pull Request → GitHub PR - Bug 1506225 - Support blocking by campaign
Commit pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/971d6cf3f8f1f2b7fb8cb88340b71ad720147a03 Bug 1506225 - Support blocking by campaign in ASR
[Tracking Requested - why for this release]: This would cause different versions of the same snippet to be shown multiple times
Comment on attachment 9026768 [details] Bug 1506225 - Support blocking by campaign id in ASR [Beta/Release Uplift Approval Request] Feature/Bug causing the regression: Bug 1506225 User impact if declined: Users will see multiple snippets from the same campaign even after dismissing them. This will result in decreased performance for campaigns critical to retention/marketing goals. Is this code covered by automated tests?: Yes Has the fix been verified in Nightly?: Yes Needs manual test from QE?: Yes If yes, steps to reproduce: QA steps: Open about:newtab#asrouter Show snippets test provider messages click "Show" next to SIMPLE_TEST_1_SAME_CAMPAIGN On the actual snippet that appears, click the x to close/block the snippet Ensure that BOTH SIMPLE_TEST_1_SAME_CAMPAIGN and SIMPLE_TEST_1 are now blocked Restart, ensure they are still blocked Try unblocking one, ensure both are unblocked Try blocking another snippet (not one of the test ones mentioned above) Try blocking a CFR message List of other uplifts needed: None Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): Patch has been in nightly for at least a week and undergone manual QA String changes made/needed: None
Attachment #9026768 - Flags: approval-mozilla-beta?
I have verified this fix on the latest Nightly 65.0a1 (Build ID 20181121220101) on Windows 10, Mac 10.13.3, and Arch Linux.
Comment on attachment 9026768 [details] Bug 1506225 - Support blocking by campaign id in ASR tweak AS ability to block campaigns, approved for 64.0b12
Attachment #9026768 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
I have verified the fix on the latest Beta build 64.0b12 (Build ID 20181122182000) on Windows 10 x64, Mac 10.13.3, and Arch Linux 4.16.
You need to log in before you can comment on or make changes to this bug.