Closed Bug 1506225 Opened 10 months ago Closed 10 months ago

Support blocking by campaign id

Categories

(Firefox :: Messaging System, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 65
Iteration:
65.2 - Nov 16
Tracking Status
firefox64 --- verified
firefox65 --- verified

People

(Reporter: k88hudson, Assigned: k88hudson)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

This is required in order to support versioning of messages
Attachment #9024065 - Attachment description: GitHub Pull Request → GitHub PR - Bug 1506225 - Support blocking by campaign
Blocks: 1505929
https://hg.mozilla.org/mozilla-central/rev/9fce755a1262
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
https://hg.mozilla.org/mozilla-central/rev/a46fe158e566
Target Milestone: --- → Firefox 65
[Tracking Requested - why for this release]: This would cause different versions of the same snippet to be shown multiple times
Comment on attachment 9026768 [details]
Bug 1506225 - Support blocking by campaign id in ASR

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1506225

User impact if declined: Users will see multiple snippets from the same campaign even after dismissing them. This will result in decreased performance for campaigns critical to retention/marketing goals.

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: Yes

If yes, steps to reproduce: QA steps:

    Open about:newtab#asrouter
    Show snippets test provider messages
    click "Show" next to SIMPLE_TEST_1_SAME_CAMPAIGN
    On the actual snippet that appears, click the x to close/block the snippet
    Ensure that BOTH SIMPLE_TEST_1_SAME_CAMPAIGN and SIMPLE_TEST_1 are now blocked
    Restart, ensure they are still blocked
    Try unblocking one, ensure both are unblocked
    Try blocking another snippet (not one of the test ones mentioned above)
    Try blocking a CFR message

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Patch has been in nightly for at least a week and undergone manual QA

String changes made/needed: None
Attachment #9026768 - Flags: approval-mozilla-beta?
Flags: qe-verify+
I have verified this fix on the latest Nightly 65.0a1 (Build ID 20181121220101) on Windows 10, Mac 10.13.3, and Arch Linux.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Comment on attachment 9026768 [details]
Bug 1506225 - Support blocking by campaign id in ASR

tweak AS ability to block campaigns, approved for 64.0b12
Attachment #9026768 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
I have verified the fix on the latest Beta build 64.0b12 (Build ID 20181122182000) on Windows 10 x64, Mac 10.13.3, and Arch Linux 4.16.
Flags: qe-verify+
Attachment #9026768 - Attachment is obsolete: true
Component: Activity Streams: Newtab → Messaging System
You need to log in before you can comment on or make changes to this bug.