1506234 - When merging users in BMO, the BMO ids in Phabricator can become out of sync causing phabbugz to stall

Status: RESOLVED DUPLICATE of bug 1506258

(Conduit :: Phabricator, defect)

Description

[David Lawrence [:dkl]]

ckolos> dkl: I think it's this: Nov 09 19:39:20 ip-172-31-33-198 docker-phabbugz[22418]: {"Fields":{"msg":"REVISION CHANGE FOUND: D3103: Bug 1479769 - Policy: Homepage now correctly sets homepage URLs with anchors | bug: 1479769 | Felipe | Felipe resigned from D3103: Bug 1479769 - Policy: Homepage now correctly sets homepage URLs with
2:40 PM <ckolos> anchors.","type":"FEED"},"Hostname":"ip-172-31-33-198","Logger":"STDERR","Pid":"8","Type":"Bugzilla.Extension.PhabBugz.Feed","Timestamp":1541792360000000000,"EnvVersion":2,"Severity":6}
2:41 PM dylan → dylan|lunch
2:41 PM <dylan|lunch> bbs
2:44 PM <dkl> ckolos: ok looking
2:46 PM <dkl> so Felipe is a bmo user
2:46 PM <dkl> so they should be linked
2:46 PM <ckolos> Nov 09 19:46:11 ip-172-31-33-198 docker-phabbugz[22418]: {"Fields":{"msg":"STORY TEXT: Radu Iman <[e-mail]> committed rBUILDPUPPETa03a988637d3: Scheduled weekly dependency update for week 44 (#291) (authored by pyup.io bot
2:46 PM <ckolos> <[e-mail]>).","type":"FEED"},"Hostname":"ip-172-31-33-198","Logger":"STDERR","Pid":"8","Type":"Bugzilla.Extension.PhabBugz.Feed","Timestamp":1541792771000000000,"EnvVersion":2,"Severity":6} maybe?
2:51 PM <ckolos> I dunno man, it's just looping over and over across those
2:51 PM <mars> dkl, I see in the All Revisions log a bunch of stuff about the "gfx" user.  Mark was talking about ripping out that stuff earlier today.  Maybe that happened, nuked the gfx user and triggered the "can_see_bug" stuff?
2:52 PM <dkl> maybe. it is the author of D3103 that is causing the error
2:52 PM <mars> ah nm then
2:52 PM <dkl> Kanika Saini
2:52 PM <dkl> isnt linked to BMO somehow
2:52 PM <dkl> i didnt think users could create accounts that were not linked
3:03 PM <dkl> ckolos: so in the phab DB the Kanika account had an address of [e-mail] but that account doesn't exist in the BMO DB
3:04 PM <dkl> so am im think she was an intern or something and is no longer with Mozilla and the mozilla account was merged with a personal account of a different BMO id
3:04 PM <dkl> so by changing the BMO id in the Phab DB to match the personal account, it was able to find it
3:04 PM <dkl> the bug attachment for the phab revision on the linked bug had the personal account as the attacher of the phab revision attachment
3 [review]:05 PM <dkl> so a merging of the two accounts would explain that at least
3:05 PM <•mcote> Ah we don't handle that eh
3:05 PM <dkl> contrator? is that a devops term?
3:06 PM <dkl> mars: yeah after the initial account creation in Phabricator we do not sync any account changes from BMO to Phab
3:06 PM <dkl> if a user is aware of the issue, they can relink to their new BMO account in there preferences in Phab but they would probably not think to do that
3:09 PM <dkl> not to mention if they still have their mozilla.com address in Phabricator, they will not receive any emails from Phabricator as well
3:09 PM <mars> dkl: re: the original error in the logs: if the exception for the missing account was at Feed.pm:428, I would wonder why the missing value for $revision->author->bugzilla_user wasn't caught sooner during code excecution.  I guess it depends how the $revision object is constructed.
3:10 PM <dkl> yeah
3:10 PM <dkl> bugzilla_user is lazy loaded

Comment 1

[David Lawrence [:dkl]]

To solve this issue at the time I did the following:

1. Shelled into the the Phab DB
$ ssh phab-prod
$ sudo docker exec -it mozphab sh
$ /app/phabricator/bin/storage shell
> connect phabricator_user;
> select accountID from user_externalaccount where username = 'KanikaSaini';
accountID is the BMO internal user ID.
2. Went to the bug id linked to in the Phab revision
3. Saw the attachment author of the Phab revision was not the same as the actual author of the revision.
4. Clicked Edit on the attachment author menu (need editusers permissions) and when to BMO edit user page.
5. Noted the BMO internal ID was not the same as the accountID from above. 
6. Took the internal BMO id and update the user_externalaccount row to match.
> update user_externalaccount set accountID = 612529 were username = 'KanikaSaini';

Afterwards Phabbugz was able to match the two and the queue continued.