1506286 - LoopingState incorrectly discards audio data

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P2)

Description

[Alastor Wu [:alwu]]

`mMaster->mCurrentPosition` is always smaller or equal than `mAudioLoopingOffset` [1] because `mMaster->mCurrentPosition` is the time which doesn't be adjusted, and that causes incorrectly discarding audio data.

We should use clock time here. 

[1] https://searchfox.org/mozilla-central/rev/a3894a4dcfb5d42f2e6eee6cb9faf7141879ef1a/dom/media/MediaDecoderStateMachine.cpp#971

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1506286 - part1 : use clock time to decide whether need to discard data.

Should use both adjusted time to do time comparison.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1506286 - part2 : finish queue after discarding data.

After discarding looping data, all data playback need are all in the queue. There is no need to
request more data, so we should finish the queue and disconnect the request.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ad50b98f99f
part1 : use clock time to decide whether need to discard data. r=jya
https://hg.mozilla.org/integration/autoland/rev/7d4844c4c21d
part2 : finish queue after discarding data. r=jya

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/2ad50b98f99f
https://hg.mozilla.org/mozilla-central/rev/7d4844c4c21d