1506341 - [Linux] Window controls appear to move up when showing the autohiding menu bar

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P3)

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1506341 - Let the autohiding menu bar match the tab bar's height. r?stransky

Comment 2

[Martin Stránský [:stransky] (ni? me)]

The icons still jump a bit when drag space is disabled (I expect the skip size is drag space/2) - is that an intention?

Comment 3

[Dão Gottwald [:dao]]

(In reply to Martin Stránský [:stransky] from comment #2)
> The icons still jump a bit when drag space is disabled (I expect the skip
> size is drag space/2) - is that an intention?

Seems to work fine over here on Ubuntu, but depending on the text and button sizes there may be cases where this solution will fall short. E.g. --tab-min-height is only a minimum height, it doesn't necessarily reflect how tall the tab bar actually is.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Okay, I don't have a strong opinion here so it's up to you.

Comment 5

[Dão Gottwald [:dao]]

I mean I'm open to ideas but I don't see a good way to fix this in every scenario. So unless this patch somehow makes the situation worse in your situation, we should still take it.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c65f689903f6
Let the autohiding menu bar match the tab bar's height. r=stransky

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/c65f689903f6