1506345 - Fennec cold start:- progress bar appears briefly then disappears

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Session Restore, defect, P3)

Description

[Mark]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/604.4.7 (KHTML, like Gecko) Version/11.0.2 Safari/604.4.7

Steps to reproduce:

Kill & relaunch Fennec Nightly (or any other Fennec)

1. The blue progress bar appears at about 10% across the screen, for a second or two
2. Then it disappears, no progress bar for a couple of seconds
3. Then it restarts and does its normal page load animation.

The appearance/disappearance/reappearance looks unpolished.

Comment 1

[Jan Henning [:JanH]]

When restoring a foreground tab, it is opened to load at its current session history entry, but the process of actually restoring the full session resets that load.
Maybe we could have those tabs load about:blank initially, although a naive implementation might have its own set of problems (about:blank briefly flashing up in the URL bar, which wouldn't really be better than the current progress bar dance).

Comment 2

[Jan Henning [:JanH]]

(In reply to Jan Henning [:JanH] from comment #1)
> [...] but the process of actually restoring the full session resets
> that load.

That should more properly read "but the process of actually restoring the full session *history* resets that load."

Comment 3

[Mark]

(In reply to Jan Henning [:JanH] from comment #1)
> Maybe we could have those tabs load about:blank initially, although a naive
> implementation might have its own set of problems (about:blank briefly
> flashing up in the URL bar, which wouldn't really be better than the current
> progress bar dance).

Yuk. Focus does this at the moment, it's even more unpolished than Fennec. I think geckoview_example.apk does too.

https://github.com/mozilla-mobile/focus-android/issues/3473 is an issue about it.

Comment 5

[csheany]

Would you mind clarifying a foreground tab?

I wonder if this will be helped by Bug 1499874.

Comment 6

[Jan Henning [:JanH]]

(In reply to csheany from comment #5)
> I wonder if this will be helped by Bug 1499874.

No.

> Would you mind clarifying a foreground tab?

When the tab that is being restored is the also the (new) currently selected tab, and we're therefore restoring the tab for real.
If a tab is being restored in background (e.g. when you use "Restore all" with multiple tabs, or if you had multiple tabs open and your session is being restored on startup), we
a) normally don't even load anything other than the one tab that's in foreground and
b) even if we did, you wouldn't see their progress bars.

Comment 7

[csheany]

Have there been any intentional changes?

This seems like a regression.

Comment 8

[csheany]

Attachment: 2019_03_06_20_49_24.mp4

Comment 9

[csheany]

Is is possible to restore the Australis behavior?

Comment 10

[Jan Henning [:JanH]]

No idea.

Comment 11

[csheany]

It sounded like it should have been happening back then as well but it wasn't.

What affected the visual aspect?

Comment 12

[csheany]

The situation may have improved a little bit.

Would you happen to know why?

Comment 13

[csheany]

Relaunching did but current session did not.

Comment 14

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.