1506384 - Unexpected blocked author status when re-landing

Status: RESOLVED DUPLICATE of bug 1489126

(Conduit :: Lando, enhancement)

Description

[Ed Lee :Mardak]

I was trying to re-land https://lando.services.mozilla.com/D11375/ and saw a Blocked status:

Diff does not have proper author information in Phabricator. This can happen if the diff was created using the web UI, or a non standard client.

Viewing the revision in Phabricator shows:

https://phabricator.services.mozilla.com/D11375
Authored by r1cky on Thu, Nov 8, 1:43 PM.

Not sure if it's because this previously landed, got backed out, so we reopened it.

Comment 1

[Ed Lee :Mardak]

Just noting that the couple "Failed to land" are unrelated as I didn't realize when attempting to reland, the patch had only been reverted from mozilla-central and not from autoland.

The bug here of missing author Blocked landing until r1cky ran `arc diff` again (with no changes I believe).

Comment 2

[:glob ✱]

https://wiki.mozilla.org/Phabricator/FAQ#How_do_I_reopen_an_existing_revision_to_submit_more_updates_for_review_.28e.g._following_a_backout.29.3F

> Note that you will need to run "arc diff" again to update the patch even if you don't need to change it (e.g. the bustage was in an earlier commit). This is because Phabricator updates the revision after it lands but does not provide the necessary metadata that Lando needs. See bug 1489126.