1506410 - Make sure wptmanifest's ParseError prints out the filename and linenumber when raised

Status: RESOLVED FIXED

(Testing :: web-platform-tests, enhancement)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I'm making a lot of changes to wpt expectation metadata to get wpt running against Fennec, and during parts of that, I seem to have introduced some syntax errors into the metadata files, causing a few wpt test chunks to fail.

One of those failures actually shows the filename with the syntax error[1] (just some whitespace/indentation issues[2]), but another one doesn't[3] (I put the "disabled:" part on the wrong line[4]).

I think it'd be nice to always print out the file with the failure. 

Or maybe have a lint job running in CI against the wpt metadata?


1. https://treeherder.mozilla.org/logviewer.html#?job_id=210910419&repo=try&lineNumber=1230
2. https://hg.mozilla.org/try/diff/fcb80af93385/testing/web-platform/meta/orientation-event/idlharness.window.js.ini
3. https://treeherder.mozilla.org/logviewer.html#?job_id=210926280&repo=try
4. https://hg.mozilla.org/try/diff/fcb80af93385/testing/web-platform/meta/media-source/mediasource-getvideoplaybackquality.html.ini

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Bug 1506410 - Make sure wptmanifest's ParseError prints out filename and line number when called r?jgraham

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Seems there were a few instances in parser.py where ParseError is raised with no parameters passed in, which is where the "__init__ takes exactly 4 arguments (1 given)" errors were coming from. This patch fixes two of those. There are still two more in that file, but I wasn't sure what exactly they were checking, so I didn't fix those in here.

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Bug 1506410 - Fix up two other instances of ParseError not passing in metadata r?jgraham

Depends on D11575

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Guessed on what that last one was checking. Happy to change the detail message to something more informative if you have a better message.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6509b248af4
Make sure wptmanifest's ParseError prints out filename and line number when called r=jgraham

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/14019 for changes under testing/web-platform/tests

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/702485851935
Fix up two other instances of ParseError not passing in metadata r=jgraham

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 9

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/b6509b248af4
https://hg.mozilla.org/mozilla-central/rev/702485851935

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged