1506479 - Discard TypeScripts in Zone::discardJitCode instead of during type sweeping

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Jan de Mooij [:jandem]]

For bug 1499644 I want to add ICScript to TypeScript to not increase sizeof(JSScript). This however introduces some browser-only shutdown GC leaks because the cycle collector traces too many things during its shutdown GC/CC. This is because we purge TypeScripts during type sweeping and this happens after marking.

I think the best fix for this is to move TypeScript discarding to Zone::discardJitCode. This is also nice because it means we can discard JIT code + TypeScript before we attempt to relazify functions during shrinking GC (so relazification becomes more effective).

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1506479 - Discard TypeScripts in Zone::discardJitCode instead of during type sweeping. r?bhackett

I also had to make some small changes to relazification for XDR tests for that to pass.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9018814d9671
Discard TypeScripts in Zone::discardJitCode instead of during type sweeping. r=bhackett

Comment 3

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/9018814d9671